Skip to content

Commit

Permalink
feat: update forge-core dep and other minor fixes (#620)
Browse files Browse the repository at this point in the history
  • Loading branch information
DRiFTy17 authored Jun 7, 2024
1 parent e8d3c40 commit 57fc254
Show file tree
Hide file tree
Showing 8 changed files with 34 additions and 11 deletions.
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
},
"dependencies": {
"@floating-ui/dom": "^1.6.5",
"@tylertech/forge-core": "^3.0.0-next.0",
"@tylertech/forge-core": "^3.0.0-next.1",
"@tylertech/tyler-icons": "^1.12.0",
"imask": "^6.6.1",
"tslib": "^2.6.3"
Expand Down
17 changes: 17 additions & 0 deletions src/lib/badge/badge-component-delegate.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { BaseComponentDelegate, IBaseComponentDelegateConfig, IBaseComponentDelegateOptions } from '../core/delegates/base-component-delegate';
import { IBadgeComponent } from './badge';
import { BADGE_CONSTANTS } from './badge-constants';

export type BadgeComponentDelegateProps = Partial<IBadgeComponent>;
export interface IBadgeComponentDelegateOptions extends IBaseComponentDelegateOptions {}
export interface IBadgeComponentDelegateConfig extends IBaseComponentDelegateConfig<IBadgeComponent, IBadgeComponentDelegateOptions> {}

export class BadgeComponentDelegate extends BaseComponentDelegate<IBadgeComponent, IBadgeComponentDelegateOptions> {
constructor(config?: IBadgeComponentDelegateConfig) {
super(config);
}

protected _build(): IBadgeComponent {
return document.createElement(BADGE_CONSTANTS.elementName);
}
}
1 change: 1 addition & 0 deletions src/lib/badge/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { defineCustomElement } from '@tylertech/forge-core';

import { BadgeComponent } from './badge';

export * from './badge-component-delegate';
export * from './badge-constants';
export * from './badge';

Expand Down
5 changes: 4 additions & 1 deletion src/lib/button/_core.scss
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,9 @@
}

@mixin with-anchor {
display: block;
display: flex;
justify-content: stretch;
align-items: stretch;
padding: 0;
}

Expand All @@ -82,6 +84,7 @@
align-items: center;
justify-content: center;
gap: #{token(spacing)};
width: 100%;

padding: #{token(padding)};

Expand Down
2 changes: 1 addition & 1 deletion src/lib/inline-message/_core.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
@forward './token-utils';

@mixin host {
display: flex;
display: block;
}

@mixin base {
Expand Down
2 changes: 1 addition & 1 deletion src/lib/list/list-item/list-item-constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,6 @@ export const LIST_ITEM_CONSTANTS = {
events
};

export interface IListItemSelectEventData<T = unknown> {
export interface IListItemSelectEventData<T = any> {
value: T;
}
2 changes: 2 additions & 0 deletions src/stories/components/button/Button.stories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { type Meta, type StoryObj } from '@storybook/web-components';
import { standaloneStoryParams, customElementStoryRenderer, generateCustomElementArgTypes, GLOBAL_THEME_OPTIONS } from '../../utils';
import { tylIconForgeLogo } from '@tylertech/tyler-icons/custom';
import { IconRegistry } from '@tylertech/forge/icon/icon-registry';
import { tylIconOpenInNew } from '@tylertech/tyler-icons/standard';

import '@tylertech/forge/button';
import '@tylertech/forge/icon';
Expand Down Expand Up @@ -69,6 +70,7 @@ export const Anchor: Story = {
variant: 'raised'
},
render: ({ variant }) => {
IconRegistry.define(tylIconOpenInNew);
return html`
<forge-button .variant=${variant}>
<a href="javascript: void(0);">
Expand Down

0 comments on commit 57fc254

Please sign in to comment.