feat(text-field): create a custom spinner for number inputs #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Describe the new behavior?
Created a new Spinner component to replace the native spinner in
<input type="number" />elements. The native version is misaligned with the Text Field component and inconsistent between browsers.Additional information
This is currently intended only for use within the library. Because input fields already expose controls for accessibility the Spinner component is essentially hidden from the accessibility tree and keyboard interaction.
The major hurdle in adding this to the Text Field component is going to be hiding the native spinner. This can be done by targeting
input[type="number"]::-webkit-inner-spin-button(or using-moz-appearance: textfieldin Firefox) but because this involves a pseudo-element it doesn't seems to be feasible from the shadow DOM.