feat(button-area): create button area component #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
DRiFTy17
reviewed
Jun 15, 2023
There was a problem hiding this comment.
This is looking great so far! A few very minor comments below.
One other thing I noticed was that when clicking on the icon-button within the button-area, it also triggered the ripple animation on the button area as well. We will probably want to avoid that?
Also, for demo purposes when it comes time for docs maybe we could use this in an expansion panel with the accessibility attributes hooked up to come full circle on that pattern?
DRiFTy17
reviewed
Oct 11, 2023
DRiFTy17
approved these changes
Oct 12, 2023
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Describe the new behavior?
This introduces a new button area component that listens for clicks while using a visually hidden button element to accessibly enable complex and interactive nested content in clickable areas.