Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(calendar): fixed a bug where an exception was being thrown if min/max was set and caused the current month to have no selectable dates. The calendar will now automatically move to the closest month with a selectable date #392

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

DRiFTy17
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added/updated: Y
  • Docs have been added/updated: N
  • Does this PR introduce a breaking change? N
  • I have linked any related GitHub issues to be closed when this PR is merged? Y

Describe the new behavior?

The calendar will now default to a month with selectable dates if min/max is set that doesn't allow dates within the current month to be selected.

Additional information

Fixes #387

…n/max was set and caused the current month to have no selectable dates. The calendar will now automatically move to the closest month with a selectable date
@DRiFTy17 DRiFTy17 added the patch Increment the patch version when merged label Sep 27, 2023
@DRiFTy17 DRiFTy17 requested a review from a team as a code owner September 27, 2023 15:56
@stackblitz
Copy link

stackblitz bot commented Sep 27, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@DRiFTy17 DRiFTy17 merged commit de9f8ac into main Sep 27, 2023
@DRiFTy17 DRiFTy17 deleted the fix/calendar-min-max-month branch September 27, 2023 19:19
@github-actions github-actions bot added the released This issue/pull request has been released. label Sep 27, 2023
@github-actions
Copy link
Contributor

🚀 PR was released in v3.0.0-next.12 🚀

@github-actions github-actions bot added the prerelease This change relates to a prerelease. label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged prerelease This change relates to a prerelease. released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datepicker with min prop specified is erroring when the date value is undefined/null
2 participants