Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(icon): move aria-hidden from host element to svg #396

Merged
merged 2 commits into from
Oct 4, 2023
Merged

feat(icon): move aria-hidden from host element to svg #396

merged 2 commits into from
Oct 4, 2023

Conversation

samrichardsontylertech
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added/updated: N
  • Docs have been added/updated: N (docs still applicable)
  • Does this PR introduce a breaking change? N
  • I have linked any related GitHub issues to be closed when this PR is merged? Y

Describe the new behavior?

Moved aria-hidden="true" from the host element to the inner SVG, keeping the same behavior while making it easier to add semantics to an icon.

Closes #395

@samrichardsontylertech samrichardsontylertech requested a review from a team as a code owner September 29, 2023 01:43
@stackblitz
Copy link

stackblitz bot commented Sep 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the minor Increment the minor version when merged label Sep 29, 2023
DRiFTy17
DRiFTy17 previously approved these changes Oct 4, 2023
View reviewed changes
@DRiFTy17 DRiFTy17 added patch Increment the patch version when merged and removed minor Increment the minor version when merged labels Oct 4, 2023
@DRiFTy17 DRiFTy17 merged commit 9b6fdff into main Oct 4, 2023
@DRiFTy17 DRiFTy17 deleted the fix/icon-a11y branch October 4, 2023 18:10
@github-actions github-actions bot added the released This issue/pull request has been released. label Oct 4, 2023
@github-actions
Copy link
Contributor

🚀 PR was released in v3.0.0-next.12 🚀

@github-actions github-actions bot added the prerelease This change relates to a prerelease. label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DRiFTy17 DRiFTy17 DRiFTy17 approved these changes

Assignees
No one assigned
Labels
accessibility patch Increment the patch version when merged prerelease This change relates to a prerelease. released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[icon] enable semantics on host element while removing them from inner SVG
2 participants
@samrichardsontylertech @DRiFTy17