Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chip field): add member on blur #408

Merged
merged 19 commits into from
Oct 27, 2023
Merged

feat(chip field): add member on blur #408

merged 19 commits into from
Oct 27, 2023

Conversation

nickonometry
Copy link
Contributor

@nickonometry nickonometry commented Oct 13, 2023 •
edited by DRiFTy17
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added/updated: Y
  • Docs have been added/updated: Y
  • Does this PR introduce a breaking change? N
  • I have linked any related GitHub issues to be closed when this PR is merged? N

Describe the new behavior?

Added a new property/attribute (addMemberOnBlur) to the chip-field that modifies the default behavior of onBlur(). By default, if you type a value into the input and tab or click away, your text disappears and the value is cleared. When enabled, this new property will emit the add-member event now.

@stackblitz
Copy link

stackblitz bot commented Oct 13, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the minor Increment the minor version when merged label Oct 13, 2023
@nickonometry nickonometry self-assigned this Oct 26, 2023
@nickonometry nickonometry added enhancement New feature or request feature request labels Oct 26, 2023
@nickonometry nickonometry marked this pull request as ready for review October 26, 2023 14:13
@nickonometry nickonometry requested a review from a team as a code owner October 26, 2023 14:13
@DRiFTy17 DRiFTy17 changed the title Origin/feat/chip field add value on blur feat(chip field): add value on blur Oct 26, 2023
@nickonometry nickonometry changed the title feat(chip field): add value on blur feat(chip field): add member on blur Oct 26, 2023
samrichardsontylertech
samrichardsontylertech reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@samrichardsontylertech samrichardsontylertech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change here overall but addMemberOnBlur feels unnecessarily wordy to me. How about changing it to add-on-blur or update-on-blur? If another component needs similar behavior in the future it might be smart to give it a portable name

@DRiFTy17 DRiFTy17 merged commit f2835dd into main Oct 27, 2023
5 checks passed
@DRiFTy17 DRiFTy17 deleted the origin/feat/chip-field-add-value-on-blur branch October 27, 2023 19:02
@github-actions github-actions bot added the released This issue/pull request has been released. label Oct 27, 2023
@github-actions GitHub Actions
Copy link
Contributor

🚀 PR was released in v3.0.0-next.13 🚀

@github-actions github-actions bot added the prerelease This change relates to a prerelease. label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samrichardsontylertech samrichardsontylertech samrichardsontylertech approved these changes

@DRiFTy17 DRiFTy17 Awaiting requested review from DRiFTy17

@Ross-Blakeney Ross-Blakeney Awaiting requested review from Ross-Blakeney

Assignees

@nickonometry nickonometry

Labels
enhancement New feature or request feature request minor Increment the minor version when merged prerelease This change relates to a prerelease. released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickonometry @samrichardsontylertech @DRiFTy17