Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): fixed a bug where options that contain leading whitespace could not be selected via keyboard filtering #414

Merged
merged 1 commit into from
Oct 27, 2023
Merged

fix(select): fixed a bug where options that contain leading whitespace could not be selected via keyboard filtering #414

merged 1 commit into from
Oct 27, 2023

Conversation

DRiFTy17
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added/updated: Y
  • Docs have been added/updated: N
  • Does this PR introduce a breaking change? N
  • I have linked any related GitHub issues to be closed when this PR is merged? Y

Describe the new behavior?

Options that contain leading whitespace will now be properly included in the keyboard filtering functionality.

Additional information

Fixes #413

@DRiFTy17
fix(select): fixed a bug where options that contain leading whitespac…
cde3cf2 
…e could not be selected via keyboard filtering
@DRiFTy17 DRiFTy17 added the patch Increment the patch version when merged label Oct 21, 2023
@DRiFTy17 DRiFTy17 requested a review from a team as a code owner October 21, 2023 16:15
@stackblitz
Copy link

stackblitz bot commented Oct 21, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@DRiFTy17 DRiFTy17 merged commit 52a0bec into main Oct 27, 2023
8 checks passed
@DRiFTy17 DRiFTy17 deleted the fix/select-filter-whitespace branch October 27, 2023 18:59
@github-actions github-actions bot added the released This issue/pull request has been released. label Oct 27, 2023
@github-actions GitHub Actions
Copy link
Contributor

🚀 PR was released in v3.0.0-next.13 🚀

@github-actions github-actions bot added the prerelease This change relates to a prerelease. label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samrichardsontylertech samrichardsontylertech samrichardsontylertech approved these changes

@Ross-Blakeney Ross-Blakeney Awaiting requested review from Ross-Blakeney

@tyl-paul-lapczynski tyl-paul-lapczynski Awaiting requested review from tyl-paul-lapczynski

Assignees
No one assigned
Labels
patch Increment the patch version when merged prerelease This change relates to a prerelease. released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[select] filtering options via keyboard doesn't work with leading whitespace
2 participants
@DRiFTy17 @samrichardsontylertech