fix(table): sortable column headers will now use <button> element for a11y purposes
#416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or a11y purposes
|
|
| @@ -979,6 +986,16 @@ export class TableFoundation implements ITableFoundation { | |||
| this._headCellMouseDownIndex = undefined; | |||
| } | |||
|
|
|||
| private _onSortableHeadCellKeydown(evt: KeyboardEvent): void { | |||
There was a problem hiding this comment.
Should this use click events instead of keydown and mousedown now that it's a button?
There was a problem hiding this comment.
I had the same thought, but when I went to adjust that I realized the mousedown handler is currently overloaded to support multiple pieces of functionality and I didn't have the time to refactor everything out.
If we want to hold off on merging this until that is refactored, I'm fine to do so, but I don't know when I can get to it.
samrichardsontylertech
approved these changes
Oct 27, 2023
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Describe the new behavior?
Sortable table headers will now use a
<button>element to ensure they are part of the tab order to fix accessibility related issues to triggering sort changes on the columns via keyboard only.Following W3 table guidance for sortable columns here:
https://www.w3.org/WAI/ARIA/apg/patterns/table/examples/sortable-table/
We should plan to introduce an API for setting the table
<caption>as well for improved screen reader support.Additional information
Fixes #63