Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@next] refactor button toggle #442

Merged
merged 4 commits into from
Dec 12, 2023
Merged

[@next] refactor button toggle #442

merged 4 commits into from
Dec 12, 2023

Conversation

DRiFTy17
Copy link
Collaborator

No description provided.

@DRiFTy17 DRiFTy17 added minor Increment the minor version when merged @next labels Dec 12, 2023
@DRiFTy17 DRiFTy17 requested a review from a team as a code owner December 12, 2023 14:05
@stackblitz StackBlitz
Copy link

stackblitz bot commented Dec 12, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@DRiFTy17
fix(calendar): fixed a bug where setting a min date to the following …
00e41b1 
…year would not properly default the initial month/year to the correct date
samrichardsontylertech
samrichardsontylertech requested changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@samrichardsontylertech samrichardsontylertech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for color contrast with some of the themes. Secondary fails WCAG AA and several of the others are borderline, only passing AA large text criteria. I don't think the text is bold enough to qualify as large text here.

samrichardsontylertech
samrichardsontylertech approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@samrichardsontylertech samrichardsontylertech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can tweak the theme colors in another PR, otherwise this looks good

@DRiFTy17 DRiFTy17 merged commit 0e90d79 into next Dec 12, 2023
6 checks passed
@DRiFTy17 DRiFTy17 deleted the next-refactor-button-toggle branch December 12, 2023 15:00
@github-actions GitHub Actions
Copy link
Contributor

🚀 PR was released in v3.0.0-next.16 🚀

@github-actions github-actions bot added the prerelease This change relates to a prerelease. label Jan 18, 2024
@github-actions github-actions bot mentioned this pull request Jan 18, 2024
Merged
This was referenced Feb 1, 2024
Merged
Merged
@github-actions github-actions bot mentioned this pull request Feb 9, 2024
Merged
This was referenced Mar 12, 2024
Merged
Merged
This was referenced Apr 11, 2024
Merged
Merged
@github-actions github-actions bot mentioned this pull request Apr 24, 2024
Merged
This was referenced May 1, 2024
Merged
Merged
This was referenced May 17, 2024
Merged
Merged
This was referenced Jun 6, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samrichardsontylertech samrichardsontylertech samrichardsontylertech approved these changes

Assignees
No one assigned
Labels
minor Increment the minor version when merged @next prerelease This change relates to a prerelease.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DRiFTy17 @samrichardsontylertech