Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@next] general cleanup, fixes, and organization #444

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

DRiFTy17
Copy link
Collaborator

@DRiFTy17 DRiFTy17 commented Dec 13, 2023

  • Renamed and organized TS mixins
  • Split default ARIA behavior into its own WithDefaultAria mixin separate from WithElementInternals
    • Added new Symbol property called observedDefaultAriaAttributes that is required on classes using WithDefaultAria
  • Added validation logic to token() Sass mixin to ensure token keys match generated token variable output, and fixed existing mismatches across all tokens
  • Added new outline-* tokens for various emphasis levels
  • Updated button toggle group tokens to use new outline emphasis tokens

@DRiFTy17 DRiFTy17 added skip-release Preserve the current version when merged @next labels Dec 13, 2023
@DRiFTy17 DRiFTy17 requested a review from a team as a code owner December 13, 2023 13:40
Copy link

stackblitz bot commented Dec 13, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@DRiFTy17 DRiFTy17 merged commit 52404a9 into next Dec 13, 2023
12 checks passed
@DRiFTy17 DRiFTy17 deleted the next-org-mixins branch December 13, 2023 14:18
Copy link
Contributor

🚀 PR was released in v3.0.0-next.16 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@next prerelease This change relates to a prerelease. skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants