Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@next] refactor setDefaultAria to use ElementInternals as fallback #445

Merged
merged 9 commits into from
Dec 14, 2023
Merged

[@next] refactor setDefaultAria to use ElementInternals as fallback #445

merged 9 commits into from
Dec 14, 2023

Conversation

DRiFTy17
Copy link
Collaborator

  • Refactored setDefaultAria
    • No longer store default ARIA values on the element as a fallback for host attributes
    • Enabled storing of default ARIA on ElementInternals as the semantic fallback
  • Updated a few components to use setDefaultAria
  • Updated global theme values to use values that pass contrast
  • Updated button toggle theme colors

@DRiFTy17
chore: refactor setDefaultAria to always set via internals ARIA p…
27a71d0 
…roperties; adjusted global theme colors to fix contrast issues
@DRiFTy17 DRiFTy17 added skip-release Preserve the current version when merged @next labels Dec 13, 2023
@DRiFTy17 DRiFTy17 requested a review from a team as a code owner December 13, 2023 21:38
@stackblitz StackBlitz
Copy link

stackblitz bot commented Dec 13, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@DRiFTy17 DRiFTy17 merged commit e6d69dc into next Dec 14, 2023
6 checks passed
@DRiFTy17 DRiFTy17 deleted the next-fix-default-aria branch December 14, 2023 15:23
@github-actions GitHub Actions
Copy link
Contributor

🚀 PR was released in v3.0.0-next.16 🚀

@github-actions github-actions bot added the prerelease This change relates to a prerelease. label Jan 18, 2024
@github-actions github-actions bot mentioned this pull request Jan 18, 2024
Merged
This was referenced Feb 1, 2024
Merged
Merged
@github-actions github-actions bot mentioned this pull request Feb 9, 2024
Merged
This was referenced Mar 12, 2024
Merged
Merged
This was referenced Apr 11, 2024
Merged
Merged
@github-actions github-actions bot mentioned this pull request Apr 24, 2024
Merged
This was referenced May 1, 2024
Merged
Merged
This was referenced May 17, 2024
Merged
Merged
This was referenced Jun 6, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samrichardsontylertech samrichardsontylertech samrichardsontylertech approved these changes

Assignees
No one assigned
Labels
@next prerelease This change relates to a prerelease. skip-release Preserve the current version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DRiFTy17 @samrichardsontylertech