Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@next] tooltip refactor #453

Merged
merged 18 commits into from
Jan 18, 2024
Merged

[@next] tooltip refactor #453

merged 18 commits into from
Jan 18, 2024

Conversation

DRiFTy17
Copy link
Collaborator

@DRiFTy17 DRiFTy17 commented Jan 17, 2024

  • Refactor the tooltip to use <forge-overlay>
  • Provides static/inline HTML support for custom content
  • Improved a11y support with the new type attribute
  • Backwards-compatible with 2.x usage and API
    • No longer sets aria-describedby by default. The element is considered presentational by default now
  • Refactored tests to WTR
  • Implement design tokens

Version

Published prerelease version: v3.0.0-next.16

Changelog

🚀 Enhancement

🐛 Bug Fix

  • [@next] refactor setDefaultAria to use ElementInternals as fallback #445 (@DRiFTy17)
  • [@next] general cleanup, fixes, and organization #444 (@DRiFTy17)
  • chore: refactor token organization and usage patterns #440 (@DRiFTy17)
  • [@next] chore: refactor slider to extend BaseFormComponent #427 (@DRiFTy17)
  • chore(list-item): improve anchor handling and semantics #423 (@DRiFTy17)
  • chore: general cleanup and consistency sweep #421 (@DRiFTy17)
  • fix: fix publish automation (@DRiFTy17)
  • fix: fix auto version calculation (@DRiFTy17)
  • [next] fix dialog story #211 (@DRiFTy17)
  • fix: package-lock sync (@DRiFTy17)
  • fix: remove base branch from shipit command (@DRiFTy17)
  • fix: update release workflow to only publish on pre-release tags (@DRiFTy17)

⚠️ Pushed to next

Authors: 2

@DRiFTy17 DRiFTy17 added minor Increment the minor version when merged @next labels Jan 17, 2024
@DRiFTy17 DRiFTy17 requested a review from a team as a code owner January 17, 2024 21:51
Copy link

stackblitz bot commented Jan 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@DRiFTy17 DRiFTy17 merged commit 455056e into next Jan 18, 2024
6 checks passed
@DRiFTy17 DRiFTy17 deleted the next-tooltip-refactor branch January 18, 2024 18:21
Copy link
Contributor

🚀 PR was released in v3.0.0-next.16 🚀

@github-actions github-actions bot added the prerelease This change relates to a prerelease. label Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged @next prerelease This change relates to a prerelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants