fix(dialog): fixed a bug where opening dialogs with focused Forge elements that use the ripple could be misaligned #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments that use the ripple could be misaligned
|
|
samrichardsontylertech
approved these changes
Feb 9, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Describe the new behavior?
Adds logic that runs after the dialog has completed animating open to attempt to fix the ripple alignment for focusable Forge elements that use a ripple.
This fix adds some slight overhead to the dialog, but it's the most seamless way to handle it at the moment for backwards compatibility. This code does not need to migrate to 3.0 and beyond due to our separation of the focus state and interaction state.
Additional information
This is a port of old logic we used to have in the 1.x version of this library. We originally removed it in 2.x because we added a JIT interaction handle for the ripple position, but the problem of the ripple being misaligned in dialogs (due to the scale animation) still exists for common things like using focus traps that set focus to the first focusable element immediately.