Next stack refactor #482
Merged
Next stack refactor #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
DRiFTy17
force-pushed
the
next-stack-refactor
branch
from
2607827 to
dbd54bd
Compare
DRiFTy17
force-pushed
the
next-stack-refactor
branch
from
dbd54bd to
f5f14a2
Compare
DRiFTy17
reviewed
Feb 22, 2024
DRiFTy17
approved these changes
Feb 23, 2024
|
🚀 PR was released in |
This was referenced Mar 12, 2024
This was referenced Apr 11, 2024
This was referenced May 1, 2024
This was referenced May 17, 2024
This was referenced Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Describe the new behavior?
Converted stack component to use design tokens. New tokens include:
Additional information
A request has come up several times to allow for vertical alignment of child items when used inline. One specific situation this was noticeable was putting two items in an inline stack that have different heights or have margin-block/padding-block applied. To resolve this, the alignment property has been updated to map to the CSS align-items property, and a new justify property has been added to control justify-content. I also added examples/demos to the EJS files to replicate the common scenarios where issues were discovered. The stack should handle all intended use cases now and mimics figmas autolayout functionality 1 to 1