Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chips): refactor to use tokens #483

Merged
merged 10 commits into from
Feb 26, 2024
Merged

feat(chips): refactor to use tokens #483

merged 10 commits into from
Feb 26, 2024

Conversation

DRiFTy17
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added/updated: Y
  • Docs have been added/updated: N
  • Does this PR introduce a breaking change? N
  • I have linked any related GitHub issues to be closed when this PR is merged? N

Describe the new behavior?

  • Refactored the <forge-chip-set> and <forge-chip> elements to use design tokens
  • Use state layer and focus indicator
  • Updated patterns, logic, styles... etc.
  • Added support for href (anchor links)
  • Reduced the overall height of the chip
  • Adjusted the field variant styles to reduce emphasis
  • Updated integration with chip field

@DRiFTy17 DRiFTy17 added minor Increment the minor version when merged skip-release Preserve the current version when merged @next labels Feb 23, 2024
@DRiFTy17 DRiFTy17 requested a review from a team as a code owner February 23, 2024 20:57
@stackblitz StackBlitz
Copy link

stackblitz bot commented Feb 23, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

samrichardsontylertech
samrichardsontylertech requested changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@samrichardsontylertech samrichardsontylertech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! I'd just like to see two small changes:

  • Arrow keys should navigate to the delete buttons from either direction
  • The delete button's focus indicator should change color to match the invalid state

@DRiFTy17 DRiFTy17 merged commit 7e0190c into next Feb 26, 2024
6 checks passed
@DRiFTy17 DRiFTy17 deleted the next-chips-refactor branch February 26, 2024 20:28
@github-actions GitHub Actions
Copy link
Contributor

🚀 PR was released in v3.0.0-next.20 🚀

@github-actions github-actions bot added the prerelease This change relates to a prerelease. label Mar 12, 2024
This was referenced Mar 12, 2024
Merged
Merged
This was referenced Apr 11, 2024
Merged
Merged
@github-actions github-actions bot mentioned this pull request Apr 24, 2024
Merged
This was referenced May 1, 2024
Merged
Merged
This was referenced May 17, 2024
Merged
Merged
This was referenced Jun 6, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samrichardsontylertech samrichardsontylertech samrichardsontylertech approved these changes

Assignees
No one assigned
Labels
minor Increment the minor version when merged @next prerelease This change relates to a prerelease. skip-release Preserve the current version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DRiFTy17 @samrichardsontylertech