Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(popover): new delay property #487

Merged
merged 15 commits into from
Feb 28, 2024
Merged

feat(popover): new delay property #487

merged 15 commits into from
Feb 28, 2024

Conversation

nickonometry
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added/updated: [Y]
  • Docs have been added/updated: [Y]
  • Does this PR introduce a breaking change? [N]
  • I have linked any related GitHub issues to be closed when this PR is merged? [Y]

Describe the new behavior?

When the trigger type of the popover was set to hover, it felt like the popover was appearing too fast. Adding the delay property keeps it consistent with the tooltip, and allows us to control the speed at which the popover element appears

@nickonometry nickonometry added enhancement New feature or request minor Increment the minor version when merged skip-release Preserve the current version when merged @next labels Feb 28, 2024
@nickonometry nickonometry self-assigned this Feb 28, 2024
@nickonometry nickonometry requested a review from a team as a code owner February 28, 2024 15:49
@stackblitz StackBlitz
Copy link

stackblitz bot commented Feb 28, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@nickonometry nickonometry changed the title feat: new delay property added to the popover feat(popover): new delay property added to the popover Feb 28, 2024
@nickonometry nickonometry changed the title feat(popover): new delay property added to the popover feat(popover): new delay property Feb 28, 2024
DRiFTy17
DRiFTy17 reviewed Feb 28, 2024
View reviewed changes
src/lib/tooltip/tooltip.test.ts Outdated Show resolved Hide resolved
src/lib/popover/popover-foundation.ts Outdated Show resolved Hide resolved
src/lib/popover/popover-foundation.ts Outdated Show resolved Hide resolved
src/dev/pages/popover/popover.html Outdated Show resolved Hide resolved
DRiFTy17
DRiFTy17 reviewed Feb 28, 2024
View reviewed changes
src/lib/tooltip/tooltip.test.ts Outdated Show resolved Hide resolved
src/lib/popover/popover.test.ts Outdated Show resolved Hide resolved
DRiFTy17
DRiFTy17 previously approved these changes Feb 28, 2024
View reviewed changes
@nickonometry nickonometry merged commit c48a748 into next Feb 28, 2024
6 checks passed
@nickonometry nickonometry deleted the next-popover-hover-delay branch February 28, 2024 17:46
@github-actions GitHub Actions
Copy link
Contributor

🚀 PR was released in v3.0.0-next.20 🚀

@github-actions github-actions bot added the prerelease This change relates to a prerelease. label Mar 12, 2024
This was referenced Mar 12, 2024
Merged
Merged
This was referenced Apr 11, 2024
Merged
Merged
@github-actions github-actions bot mentioned this pull request Apr 24, 2024
Merged
This was referenced May 1, 2024
Merged
Merged
This was referenced May 17, 2024
Merged
Merged
This was referenced Jun 6, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DRiFTy17 DRiFTy17 DRiFTy17 approved these changes

@samrichardsontylertech samrichardsontylertech Awaiting requested review from samrichardsontylertech

Assignees

@nickonometry nickonometry

Labels
enhancement New feature or request minor Increment the minor version when merged @next prerelease This change relates to a prerelease. skip-release Preserve the current version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickonometry @DRiFTy17