Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@next][button-area] refactor to use tokens, state-layer, and focus-indicator #489

Merged
merged 23 commits into from
Mar 6, 2024
Merged

[@next][button-area] refactor to use tokens, state-layer, and focus-indicator #489

merged 23 commits into from
Mar 6, 2024

Conversation

derekmoss
Copy link
Contributor

@derekmoss derekmoss commented Feb 28, 2024 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added/updated:Y
  • Docs have been added/updated: N
  • Does this PR introduce a breaking change? N
  • I have linked any related GitHub issues to be closed when this PR is merged? N

Describe the new behavior?

adds configuration tokens for

primary-color
cursor
disabled cursor
focus indicator color
focus indicator offset

adds state layer

adds focus indicator

Additional information

@derekmoss derekmoss added minor Increment the minor version when merged @next labels Feb 28, 2024
@stackblitz StackBlitz
Copy link

stackblitz bot commented Feb 28, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@derekmoss derekmoss changed the base branch from main to next February 28, 2024 19:25
@derekmoss derekmoss marked this pull request as ready for review February 28, 2024 19:48
@derekmoss derekmoss requested a review from a team as a code owner February 28, 2024 19:48
@derekmoss derekmoss requested a review from DRiFTy17 February 28, 2024 19:49
@DRiFTy17 DRiFTy17 added the skip-release Preserve the current version when merged label Feb 28, 2024
samrichardsontylertech
samrichardsontylertech requested changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@samrichardsontylertech samrichardsontylertech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! Just remove a few styles and I'll give it an approval

src/lib/button-area/_core.scss Outdated Show resolved Hide resolved
DRiFTy17
DRiFTy17 reviewed Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@DRiFTy17 DRiFTy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things are looking good! From a visual and interaction perspective I think it's great. Just some minor things below to review.

I asked @samrichardsontylertech to take a look as well since he had some plans for this component in the past.

src/lib/button-area/button-area-adapter.ts Outdated Show resolved Hide resolved
src/dev/pages/stack/stack.ejs Outdated Show resolved Hide resolved
src/lib/button-area/button-area.scss Outdated Show resolved Hide resolved
src/lib/button-area/button-area.scss Outdated Show resolved Hide resolved
src/lib/button-area/button-area.ts Outdated Show resolved Hide resolved
src/lib/button-area/button-area.test.ts Outdated Show resolved Hide resolved
DRiFTy17
DRiFTy17 previously approved these changes Mar 5, 2024
View reviewed changes
@DRiFTy17 DRiFTy17 merged commit 9df42ed into next Mar 6, 2024
6 checks passed
@DRiFTy17 DRiFTy17 deleted the next-button-area-refactor branch March 6, 2024 14:17
@derekmoss derekmoss requested a review from DRiFTy17 March 6, 2024 16:31
@github-actions GitHub Actions
Copy link
Contributor

🚀 PR was released in v3.0.0-next.20 🚀

@github-actions github-actions bot added the prerelease This change relates to a prerelease. label Mar 12, 2024
This was referenced Mar 12, 2024
Merged
Merged
This was referenced Apr 11, 2024
Merged
Merged
@github-actions github-actions bot mentioned this pull request Apr 24, 2024
Merged
This was referenced May 1, 2024
Merged
Merged
This was referenced May 17, 2024
Merged
Merged
This was referenced Jun 6, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samrichardsontylertech samrichardsontylertech samrichardsontylertech left review comments

@DRiFTy17 DRiFTy17 Awaiting requested review from DRiFTy17

Assignees
No one assigned
Labels
minor Increment the minor version when merged @next prerelease This change relates to a prerelease. skip-release Preserve the current version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@derekmoss @DRiFTy17 @samrichardsontylertech @nickonometry