Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Origin/fix tab accessibility issues #621

Merged
merged 6 commits into from
Jun 11, 2024
Merged

Origin/fix tab accessibility issues #621

merged 6 commits into from
Jun 11, 2024

Conversation

nickonometry
Copy link
Contributor

@nickonometry nickonometry commented Jun 7, 2024 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added/updated: [Y]
  • Docs have been added/updated: [N]
  • Does this PR introduce a breaking change? [N]
  • I have linked any related GitHub issues to be closed when this PR is merged? [N]

Describe the new behavior?

Fixed an A11y issue where focusable elements were found within an ARIA role that defines its children as presentational

@nickonometry nickonometry added patch Increment the patch version when merged accessibility labels Jun 7, 2024
@nickonometry nickonometry self-assigned this Jun 7, 2024
@stackblitz StackBlitz
Copy link

stackblitz bot commented Jun 7, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@DRiFTy17 DRiFTy17 marked this pull request as ready for review June 11, 2024 11:07
@DRiFTy17 DRiFTy17 requested a review from a team as a code owner June 11, 2024 11:07
@DRiFTy17 DRiFTy17 merged commit bda66a2 into main Jun 11, 2024
6 checks passed
@DRiFTy17 DRiFTy17 deleted the origin/fix-tab-accessibility-issues branch June 11, 2024 12:00
@github-actions GitHub Actions
Copy link
Contributor

🚀 PR was released in v2.24.2 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DRiFTy17 DRiFTy17 DRiFTy17 approved these changes

@Ross-Blakeney Ross-Blakeney Awaiting requested review from Ross-Blakeney

@tyl-paul-lapczynski tyl-paul-lapczynski Awaiting requested review from tyl-paul-lapczynski

@samrichardsontylertech samrichardsontylertech Awaiting requested review from samrichardsontylertech

Assignees

@nickonometry nickonometry

Labels
accessibility patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickonometry @DRiFTy17