Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): native form association and label awareness #636

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

samrichardsontylertech
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added/updated: Y
  • Docs have been added/updated: N
  • Does this PR introduce a breaking change? N
  • I have linked any related GitHub issues to be closed when this PR is merged? Y

Describe the new behavior?

The select component is now form associated and label aware.

Closes #635

Additional information

The label component has also been updated to connect to components that haven't yet been upgraded and ignore the text content of nested labelled components.

@samrichardsontylertech samrichardsontylertech added the skip-release Preserve the current version when merged label Jun 26, 2024
@samrichardsontylertech samrichardsontylertech requested a review from a team as a code owner June 26, 2024 14:57
Copy link

stackblitz bot commented Jun 26, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@DRiFTy17 DRiFTy17 added the minor Increment the minor version when merged label Jun 26, 2024
@samrichardsontylertech samrichardsontylertech merged commit acbc990 into main Jun 27, 2024
7 checks passed
@samrichardsontylertech samrichardsontylertech deleted the feat/select-form branch June 27, 2024 14:33
Copy link
Contributor

github-actions bot commented Sep 9, 2024

🚀 PR was released in v3.1.0 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released. skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[select] native form association and label awareness
2 participants