fix(field): fixed a bug where the width could collapse while the inset label animation is executing #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t label animation is executing
DRiFTy17
added
patch
|
|
samrichardsontylertech
approved these changes
Nov 1, 2024
|
🚀 PR was released in |
This was referenced Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Describe the new behavior?
When fields (text-fields for example) are used within layouts that collapse their content, such as flexbox, the field width could collapse down to the min content width while the inset/floating label animation is executing. This change ensures that the internal input container locks its width to the current width before the animation begins to avoid the collapse, and then removes the locked width after the animation completes.
Additional information
Given that this is only temporary while the animation executes, and there is no reliable CSS-based solution to it without restructuring the field component to avoid using
position: absolute, this should be adequate.