Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: update forge-core to optimize attachShadowTemplate #757

Merged
merged 3 commits into from
Nov 22, 2024
Merged

perf: update forge-core to optimize attachShadowTemplate #757

merged 3 commits into from
Nov 22, 2024

Conversation

MikeMatusz
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added/updated: n/a
  • Docs have been added/updated: n/a
  • Does this PR introduce a breaking change? N
  • I have linked any related GitHub issues to be closed when this PR is merged? n/a

Describe the new behavior?

HTML templates will now only be parsed from string format once per component, resulting in faster subsequent renders.

Additional information

@MikeMatusz MikeMatusz requested a review from a team as a code owner November 20, 2024 21:02
@stackblitz StackBlitz
Copy link

stackblitz bot commented Nov 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the skip-release Preserve the current version when merged label Nov 20, 2024
@MikeMatusz MikeMatusz added patch Increment the patch version when merged and removed skip-release Preserve the current version when merged labels Nov 20, 2024
conner-fallone
conner-fallone previously approved these changes Nov 21, 2024
View reviewed changes
@MikeMatusz MikeMatusz requested a review from DRiFTy17 November 21, 2024 13:33
@DRiFTy17 DRiFTy17 merged commit adb7a9b into main Nov 22, 2024
5 checks passed
@DRiFTy17 DRiFTy17 deleted the perf-attachShadowTemplate branch November 22, 2024 16:15
@github-actions GitHub Actions
Copy link
Contributor

🚀 PR was released in v3.3.6 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samrichardsontylertech samrichardsontylertech samrichardsontylertech left review comments

@conner-fallone conner-fallone conner-fallone left review comments

@DRiFTy17 DRiFTy17 Awaiting requested review from DRiFTy17

Assignees
No one assigned
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MikeMatusz @conner-fallone @samrichardsontylertech @DRiFTy17