Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make joinWithNever attempting self cancelling #4131

Conversation

lenguyenthanh
Copy link
Member

Close #4093 by attempting self-cancel before F.never

@lenguyenthanh lenguyenthanh changed the title Make join with never sefl cancelling Make joinWithNever attempting self cancelling Sep 8, 2024
@lenguyenthanh lenguyenthanh changed the title Make joinWithNever attempting self cancelling Make joinWithNever attempting self cancelling Sep 8, 2024
@armanbilge armanbilge added this to the v3.6.0 milestone Sep 10, 2024
@djspiewak
Copy link
Member

So the concern I have with this is that there's a lot of call-sites which kind of implicitly assume it isn't self-canceling. This is a pretty significant semantic to change. The inconsistency with the docs was actually reported back before 3.0.0 went final, and we decided that the mistaken semantic (the one presently in HEAD) was more expected, but we never went back and fixed the docs.

It think it might be better to fix the docs to match the semantic, rather than changing something like this which can have really far-reaching consequences.

@armanbilge
Copy link
Member

See also a similar confusion with embedNever in #3351 (comment).

@lenguyenthanh
Copy link
Member Author

that makes sense. I'll submit another pr for updating the docs.

@lenguyenthanh lenguyenthanh deleted the make-join-with-never-sefl-cancelling branch October 25, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential inconsistency between joinWithNever and docs
3 participants