-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Scala 3 derived support #157
Conversation
@TonioGela thanks for this! We don't currently have separate tests, but if you feel up to adding a Scala 3 specific unit test that would be great. |
Okay, I'll try to come up with some scala 3 specific tests, maybe asking for some help. Also, can I ask you a question? Is it me or I can't see a generic auto derivator that uses a generic |
I'm not sure I understand your question. To be honest, my Scala 3 knowledge is still a bit hacky, so it's possible I'm doing some less-than-ideal things in my code. I'd welcome any insights and suggestions to improve the code. |
If we speak about macro, we're in two 😄 |
Oh, you mean like how Circe has the capability to auto-derive without needing the |
@TonioGela any updates on this? I'd love to merge it. |
Sorry, last weeks have been really busy. I'll write some tests before the week ends and I'll add them to the PR so we can merge it, promess! |
@darkfrog26 I added some trivial tests with Scala3 that at least can test the derivation syntax. In another PR, I might help you add some property-based tests to the whole project. |
Great work! Thanks! |
I'm not 100% sure that this may be enough to add Scala 3 derivation support, as idk what will happen to non-product types, but "works on my machine™" on case classes.
Also, I saw that the tests are not split by version, so I'll wait for your instructions about how to test it.
Thanks :D