CLI-1383: Upgrade consolidation/self-update #366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danepowell
commented
Nov 4, 2024
| @@ -9,13 +8,12 @@ | |||
| ], | |||
| "finder": [ | |||
| { | |||
| "name": "*.php", | |||
| "name": "{\\.(php|bash|fish|zsh)}", | |||
There was a problem hiding this comment.
These are autocompletion dumps required to avoid a Symfony pseudo-bug: phpactor/phpactor#2566
|
I was able to do this without the BC break: #370 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new major version of consolidation/self-update (3.0.0) is about to drop. It has BC-breaking changes, so this library needs to update to the latest release in order to be compatible with downstream clients using the new version.
This also requires bumping the platform PHP version, and I figure we might as well drop support for EOL versions while we're at it.
There's no clean way to preserve support for older PHP versions; folks on EOL PHP versions will just use an older version of this library.