DO NOT MERGE: bad code for testing reviewer bots #40

tzachz · 2021-10-25T20:41:15Z

No description provided.

tzachz · 2021-10-25T20:44:31Z

leaderboard-server/src/main/java/com/tzachz/commentcounter/server/LeaderBoardService.java

+        for (int i = 0; i < arr.length; i++) { // expect error: for loop
+            System.out.println(arr[i]); // expect error: println
+        }
+        if ("1" == "1") { // expect error: use equals


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Problem: An equality operator (== or !=) is used to compare strings, which matches strings based on address.

Fix: Do content comparison using the equals() method to compare the values of the strings.

sonarcloud · 2021-10-25T20:49:51Z

SonarCloud Quality Gate failed.

3 Bugs
0 Vulnerabilities
0 Security Hotspots
8 Code Smells

7.7% Coverage
0.0% Duplication

ghost · 2021-10-25T20:50:33Z

leaderboard-server/src/main/java/com/tzachz/commentcounter/server/LeaderBoardService.java

+        for (int i = 0; i < arr.length; i++) { // expect error: for loop
+            System.out.println(arr[i]); // expect error: println
+        }
+        if ("1" == "1") { // expect error: use equals


[PMD Java] Use equals() to compare object references. (view)

Rule Ruleset Priority

CompareObjectsWithEquals Error Prone 3

References:

https://pmd.github.io/pmd-6.39.0/pmd_rules_java_errorprone.html#compareobjectswithequals

You can close this issue if no need to fix it. Learn more.

ghost · 2021-10-25T20:50:34Z

leaderboard-server/src/main/java/com/tzachz/commentcounter/server/LeaderBoardService.java

+    // expect error: unused
+    private String unused() {
+        String[] arr = new String[] {"a", "b"};
+        for (int i = 0; i < arr.length; i++) { // expect error: for loop


[PMD Java] This for loop can be replaced by a foreach loop (view)

Rule Ruleset Priority

ForLoopCanBeForeach Best Practices 3

References:

https://pmd.github.io/pmd-6.39.0/pmd_rules_java_bestpractices.html#forloopcanbeforeach

You can close this issue if no need to fix it. Learn more.

ghost · 2021-10-25T20:50:34Z

leaderboard-server/src/main/java/com/tzachz/commentcounter/server/LeaderBoardService.java

@@ -65,4 +80,11 @@
        executorService.scheduleAtFixedRate(new FetcherRunnable(store, fetcher), 0, configuration.getRefreshRateMinutes(), TimeUnit.MINUTES);
    }

+    // expect error: length, number of vars, unused vars, duplication, unused
+    private void createScheduledFetcher2(LeaderBoardServerConfiguration configuration, Environment environment, GitHubApiFacade apiFacade, LeaderBoardStore store, String aaa, String bbb, String ccc, String ddd) {


[PMD Java] Avoid unused method parameters such as 'aaa'. (view)

Rule Ruleset Priority

UnusedFormalParameter Best Practices 3

References:

https://pmd.github.io/pmd-6.39.0/pmd_rules_java_bestpractices.html#unusedformalparameter

You can close this issue if no need to fix it. Learn more.

ghost · 2021-10-25T20:50:34Z

leaderboard-server/src/main/java/com/tzachz/commentcounter/server/LeaderBoardService.java

@@ -65,4 +80,11 @@
        executorService.scheduleAtFixedRate(new FetcherRunnable(store, fetcher), 0, configuration.getRefreshRateMinutes(), TimeUnit.MINUTES);
    }

+    // expect error: length, number of vars, unused vars, duplication, unused
+    private void createScheduledFetcher2(LeaderBoardServerConfiguration configuration, Environment environment, GitHubApiFacade apiFacade, LeaderBoardStore store, String aaa, String bbb, String ccc, String ddd) {


[PMD Java] Avoid unused method parameters such as 'bbb'. (view)

Rule Ruleset Priority

UnusedFormalParameter Best Practices 3

References:

https://pmd.github.io/pmd-6.39.0/pmd_rules_java_bestpractices.html#unusedformalparameter

You can close this issue if no need to fix it. Learn more.

ghost · 2021-10-25T20:50:34Z

leaderboard-server/src/main/java/com/tzachz/commentcounter/server/LeaderBoardService.java

@@ -65,4 +80,11 @@
        executorService.scheduleAtFixedRate(new FetcherRunnable(store, fetcher), 0, configuration.getRefreshRateMinutes(), TimeUnit.MINUTES);
    }

+    // expect error: length, number of vars, unused vars, duplication, unused
+    private void createScheduledFetcher2(LeaderBoardServerConfiguration configuration, Environment environment, GitHubApiFacade apiFacade, LeaderBoardStore store, String aaa, String bbb, String ccc, String ddd) {


[PMD Java] Avoid unused method parameters such as 'ccc'. (view)

Rule Ruleset Priority

UnusedFormalParameter Best Practices 3

References:

https://pmd.github.io/pmd-6.39.0/pmd_rules_java_bestpractices.html#unusedformalparameter

You can close this issue if no need to fix it. Learn more.

ghost · 2021-10-25T20:50:34Z

leaderboard-server/src/main/java/com/tzachz/commentcounter/server/LeaderBoardService.java

@@ -65,4 +80,11 @@
        executorService.scheduleAtFixedRate(new FetcherRunnable(store, fetcher), 0, configuration.getRefreshRateMinutes(), TimeUnit.MINUTES);
    }

+    // expect error: length, number of vars, unused vars, duplication, unused
+    private void createScheduledFetcher2(LeaderBoardServerConfiguration configuration, Environment environment, GitHubApiFacade apiFacade, LeaderBoardStore store, String aaa, String bbb, String ccc, String ddd) {


[PMD Java] Avoid unused private methods such as 'createScheduledFetcher2(LeaderBoardServerConfiguration,Environment,GitHubApiFacade,LeaderBoardStore,String,String,String,String)'. (view)

Rule Ruleset Priority

UnusedPrivateMethod Best Practices 3

References:

https://pmd.github.io/pmd-6.39.0/pmd_rules_java_bestpractices.html#unusedprivatemethod

You can close this issue if no need to fix it. Learn more.

ghost · 2021-10-25T20:50:35Z

leaderboard-server/src/main/java/com/tzachz/commentcounter/server/LeaderBoardService.java

+        for (int i = 0; i < arr.length; i++) { // expect error: for loop
+            System.out.println(arr[i]); // expect error: println
+        }
+        if ("1" == "1") { // expect error: use equals


[PMD Java] Use equals() to compare strings instead of '==' or '!=' (view)

Rule Ruleset Priority

UseEqualsToCompareStrings Error Prone 3

References:

https://pmd.github.io/pmd-6.39.0/pmd_rules_java_errorprone.html#useequalstocomparestrings

You can close this issue if no need to fix it. Learn more.

ghost · 2021-10-25T20:50:35Z

leaderboard-server/src/main/java/com/tzachz/commentcounter/server/LeaderBoardService.java

@@ -45,7 +45,10 @@
        createScheduledFetcher(configuration, environment, apiFacade, store);
    }

-    protected GitHubApiFacade getApiFacade(LeaderBoardServerConfiguration configuration) {
+    // expect error: bad name
+    protected GitHubApiFacade GetApiFacade(LeaderBoardServerConfiguration configuration) {


[Checkstyle] Name 'GetApiFacade' must match pattern '^[a-z][a-zA-Z0-9]*$'. (view)

Rule Severity

MethodNameCheck info

References:

https://checkstyle.org/config_naming.html#MethodName

You can close this issue if no need to fix it. Learn more.

ghost · 2021-10-25T20:50:35Z

leaderboard-server/src/main/java/com/tzachz/commentcounter/server/LeaderBoardService.java

@@ -65,4 +80,11 @@
        executorService.scheduleAtFixedRate(new FetcherRunnable(store, fetcher), 0, configuration.getRefreshRateMinutes(), TimeUnit.MINUTES);
    }

+    // expect error: length, number of vars, unused vars, duplication, unused
+    private void createScheduledFetcher2(LeaderBoardServerConfiguration configuration, Environment environment, GitHubApiFacade apiFacade, LeaderBoardStore store, String aaa, String bbb, String ccc, String ddd) {


[Checkstyle] More than 7 parameters (found 8). (view)

Rule Severity

ParameterNumberCheck info

References:

https://checkstyle.org/config_sizes.html#ParameterNumber

You can close this issue if no need to fix it. Learn more.

ghost · 2021-10-25T20:50:35Z

leaderboard-server/src/main/java/com/tzachz/commentcounter/server/LeaderBoardService.java

+        for (int i = 0; i < arr.length; i++) { // expect error: for loop
+            System.out.println(arr[i]); // expect error: println
+        }
+        if ("1" == "1") { // expect error: use equals


[Checkstyle] Literal Strings should be compared using equals(), not '=='. (view)

Rule Severity

StringLiteralEqualityCheck info

References:

https://checkstyle.org/config_coding.html#StringLiteralEquality

You can close this issue if no need to fix it. Learn more.

DO NOT MERGE: bad code for testing reviewer bots

f1e09b5

tzachz commented Oct 25, 2021

View reviewed changes

tzachz closed this Oct 25, 2021

tzachz reopened this Oct 25, 2021

ghost reviewed Oct 25, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DO NOT MERGE: bad code for testing reviewer bots #40

DO NOT MERGE: bad code for testing reviewer bots #40

tzachz commented Oct 25, 2021

tzachz Oct 25, 2021

sonarcloud bot commented Oct 25, 2021

ghost Oct 25, 2021

ghost Oct 25, 2021

ghost Oct 25, 2021

ghost Oct 25, 2021

ghost Oct 25, 2021

ghost Oct 25, 2021

ghost Oct 25, 2021

ghost Oct 25, 2021

ghost Oct 25, 2021

ghost Oct 25, 2021

DO NOT MERGE: bad code for testing reviewer bots #40

Are you sure you want to change the base?

DO NOT MERGE: bad code for testing reviewer bots #40

Conversation

tzachz commented Oct 25, 2021

Choose a reason for hiding this comment

sonarcloud bot commented Oct 25, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment