Pipelining followups #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzaffi
commented
Aug 29, 2023
Comment on lines
-699
to
-700
|
|
||
| <-p.ctx.Done() |
There was a problem hiding this comment.
This is the health endpoint bugfix.
added 2 commits
August 28, 2023 22:13
tzaffi
commented
Aug 29, 2023
| // RetriesNoOutput applies the same logic as Retries, but for functions that return no output. | ||
| func RetriesNoOutput[X pluginInput](f func(x X) error, a X, p *pipelineImpl, msg string) (time.Duration, error) { | ||
| _, d, err := Retries(func(x X) (empty, error) { | ||
| // TODO: probly the following function and its unit test should be axed |
There was a problem hiding this comment.
I agree that we probably don't need a no-input function right now -- is this+tests+above interface going to be reverted?
tzaffi
commented
Aug 29, 2023
tzaffi
commented
Aug 29, 2023
algochoi
reviewed
Aug 29, 2023
| @@ -135,3 +140,41 @@ func TestLogFile(t *testing.T) { | |||
| require.Contains(t, dataStr, "\nWriting logs to file:") | |||
| }) | |||
| } | |||
|
|
|||
| func TestHealthEndpoint(t *testing.T) { | |||
| // RetriesNoOutput applies the same logic as Retries, but for functions that return no output. | ||
| func RetriesNoOutput[X pluginInput](f func(x X) error, a X, p *pipelineImpl, msg string) (time.Duration, error) { | ||
| _, d, err := Retries(func(x X) (empty, error) { | ||
| // TODO: probly the following function and its unit test should be axed |
There was a problem hiding this comment.
I agree that we probably don't need a no-input function right now -- is this+tests+above interface going to be reverted?
|
closing this PR and will re-open a new one shortly against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: algorand#147 for the continuation of this work