Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the string regex attribute of matchers to regex #213

Merged
merged 1 commit into from
Jul 13, 2024

Commits on Jul 13, 2024

  1. Rename the string regex attribute of matchers to regex

    It's kinda dumb that I didn't do that in the first place and I'm not
    entirely sure why I missed it...
    
    Anyway there is no reason to make `pattern` be the string pattern and
    `regex` be the compiled pattern, that unnecessarily diverges from the
    regexes.yaml naming for the corresponding attribute which is a shame,
    and the compiled regex in python is... `re.Pattern`, so it makes more
    sense on both axis to have `pattern: re.Pattern[str]` and `regex:
    str`.
    
    Also add a `regex_flag` attribute/property on the device matchers for
    the string version of the flags.
    masklinn committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    ad01dd4 View commit details
    Browse the repository at this point in the history