Optimise pyo3 use #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this has not been profiled, it seems rather unlikely that the python implementation uses the same allocator as Rust (whether system or other). This means *returning* a `String` is an extra allocation as that will need to be copied again to a `PyString` on the ouput. Which is just dumb. Copy the internal `Cow` directly to a `PyString` on output. On input, a `String` is necessary as there's no way to lifetime properly from Python, so the extractors need to be `'static`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this has not been profiled, it seems rather unlikely that the python implementation uses the same allocator as Rust (whether system or other). This means returning a
Stringis an extra allocation as that will need to be copied again to aPyStringon the ouput. Which is just dumb.Copy the internal
Cowdirectly to aPyStringon output. On input, aStringis necessary as there's no way to lifetime properly from Python, so the extractors need to be'static.