Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust-dev-env] This project has no stable releases and is a massive time sink. #27

Open
rrbutani opened this issue Sep 26, 2017 · 1 comment
Labels

Comments

@rrbutani
Copy link
Member

No description provided.

@bbridges
Copy link
Member

Yeah rip

rrbutani added a commit that referenced this issue Sep 28, 2017
Most notably, Xming should install correctly now and no longer runs in access control disabled mode (X0.hosts configured properly)
Additionally, some minor bug fixes.

Some notes for the future:
This really really should be restructured. The checkOS method has grown to basically become the entire script and runs a lot of things before arguments are even processed.
This makes some things work in odd ways; for example: on windows ~/Documents/UAVA is created even if a custom path is specified (and also, custom paths don't work since you need to provide docker with a Windows style path but put the unix style path in the alias)
There's also a lot of repeated code/things that really should be made functions. For example, the check grep for string/if not, add routine; the download+install .exe routine; and so on.

But, those are future problems. Unless something goes very wrong or there's a compelling reason why this script needs to be cleaned up or published, I'm inclined to leave it as is for now.

Also, I fully expect (and hope) that this script will become obsolete in the near future, as bash on windows matures and docker grows to better support different platforms.

About the versions: With this commit, I'm ready to call rust-dev-env beta software. I'm bumping the version up to 0.9.5 and changing the branches to match.
I realise 0.1.x never actually made it into master, but I think that's fine.
I want 1.0.0 to be the first 'stable' release, and since I feel like we're nearing that this is going to be 0.9.5 and that's that.

I haven't been keeping up with the issues on Github so, here's where we are:
This and prior commits:
    * close #2
    * close #6
    * fix #8
    * close #9 (probably - needs macOS testing)
    * fix #10 (and then broke it again, but that's another thing)
    * fix #11
    * close #12 (probably - also needs macOS testing)
    * close #13
    * close #14 (and we even take of Docker!)
    * started #15?
    * possibly maybe took care of #16 but needs testing
    * fix #17
    * added something like #19 to the end of the install script
    * close #20
    * close #21 (there are other issues with this, but that's for a new issue)
    * close #22
    * close #23
    * close #24 (probably - needs testing; n.b: windows users are taken care of)
    * close #26
    * #27 cannot be avoided
    * fix #28
    * fix #29
    * fix #30

Finally, shout out to Steven for helping test this script on Windows. Thanks Steven!
rrbutani added a commit that referenced this issue Sep 28, 2017
Most notably, Xming should install correctly now and no longer runs in access control disabled mode (X0.hosts configured properly)
Additionally, some minor bug fixes.

Some notes for the future:
This really really should be restructured. The checkOS method has grown to basically become the entire script and runs a lot of things before arguments are even processed.
This makes some things work in odd ways; for example: on windows ~/Documents/UAVA is created even if a custom path is specified (and also, custom paths don't work since you need to provide docker with a Windows style path but put the unix style path in the alias)
There's also a lot of repeated code/things that really should be made functions. For example, the check grep for string/if not, add routine; the download+install .exe routine; and so on.

But, those are future problems. Unless something goes very wrong or there's a compelling reason why this script needs to be cleaned up or published, I'm inclined to leave it as is for now.

Also, I fully expect (and hope) that this script will become obsolete in the near future, as bash on windows matures and docker grows to better support different platforms.

About the versions: With this commit, I'm ready to call rust-dev-env beta software. I'm bumping the version up to 0.9.5 and changing the branches to match.
I realise 0.1.x never actually made it into master, but I think that's fine.
I want 1.0.0 to be the first 'stable' release, and since I feel like we're nearing that this is going to be 0.9.5 and that's that.

I haven't been keeping up with the issues on Github so, here's where we are:
This and prior commits:
    * close #2
    * close #6
    * fix #8
    * close #9 (probably - needs macOS testing)
    * fix #10 (and then broke it again, but that's another thing)
    * fix #11
    * close #12 (probably - also needs macOS testing)
    * close #13
    * close #14 (and we even take of Docker!)
    * started #15?
    * possibly maybe took care of #16 but needs testing
    * fix #17
    * added something like #19 to the end of the install script
    * close #20
    * close #21 (there are other issues with this, but that's for a new issue)
    * close #22
    * close #23
    * close #24 (probably - needs testing; n.b: windows users are taken care of)
    * close #26
    * #27 cannot be avoided
    * fix #28
    * fix #29
    * fix #30

Finally, shout out to Steven for helping test this script on Windows. Thanks Steven! (@stevenjzhu)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants