Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PiranhaArguments from SourceCodeUnit #387

Open
ketkarameya opened this issue Feb 21, 2023 · 0 comments
Open

Remove PiranhaArguments from SourceCodeUnit #387

ketkarameya opened this issue Feb 21, 2023 · 0 comments

Comments

@ketkarameya
Copy link
Collaborator

(To expand upon that todo: Once I we reach a point when source_code_unit does not require PiranhaArguments as a whole, I will move this check related to user_defined_rules.graph().is_empty() (l. 287)) into PiranhaArgumentBuilder's validate function (and panic, rather than warn).

Currently, we just print a warning and do no change to the code bass (when no user rules are provided)

Originally posted by @ketkarameya in #380 (comment)
@ketkarameya ketkarameya changed the title [Simplified the code] Basically added _arg.rule_graph().clone() as default value for user_defined_rules. Remove PiranhaArguments from SourceCodeUnit Feb 21, 2023
@ketkarameya ketkarameya mentioned this issue Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ketkarameya