Skip to content
This repository has been archived by the owner on Nov 4, 2023. It is now read-only.

[Indicators] Add support for ayatana indicators #326

Draft
wants to merge 1 commit into
base: xenial
Choose a base branch
from

Conversation

mariogrip
Copy link
Member

This adds support for ayatana indicators but keeps the existing unity indicators to support legacy indicators, this also cleans up the indicator load logic.

This opts to add each indicator menu types to the qml object instead of doing a hacky replace string logic, this way we save cpu cycles but at a ultra minor memory bump.

This adds support for ayatana indicators but keeps the existing unity indicators to support legacy indicators, this also cleans up the indicator load logic.
Copy link
Contributor

@peat-psuwit peat-psuwit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but someone else must approve. Didn't test or anything.

As this merges to xenial branch, maybe wait for OTA-13 to be released first?

@mariogrip
Copy link
Member Author

@UniversalSuperBox what do you think?

Copy link
Member

@dobey dobey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to update/add tests and data for these changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants