This repository has been archived by the owner on Nov 4, 2023. It is now read-only.
Bring in multiscreen and workspace support #360
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes panel test by making verifying synchronous to avoid interfering with touchFlick function.
This makes sure to set surface to null when the surface is no longer live, this was done in qml before, but has been removed as the window manager should handle this, this reflect that change in the mocks.
This was done in stage when application requested forcus, but this is no longer done as it makes no sense to close spread on app start/focus
This moves surface manager to local member of WorkspaceManager insted of accessing the static object, this makes sure we catch the destroy signal in same thread as we run in.
This makes sure we unset VM objects before destruction, this makes sure we do not access a alredy destroyed object.
We are in the progress of moving to the drawer this is caused by the user pressing the bfb on unlock in this case we want to show the drawer and not just visible
ExpectFail on broken compeare instead of commenting out the whole test case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs patches to qtmir and unity-api, but i put this up here for review as a draft for now.
Tests successes locally, lets see what CI says.
Depends on: ubports/unity-api#28 and ubports/qtmir#63