Skip to content
This repository has been archived by the owner on Nov 4, 2023. It is now read-only.

Notch support #442

Open
wants to merge 4 commits into
base: xenial
Choose a base branch
from

Conversation

ilyakooo0
Copy link

This is a rebased version of #403

I don't really understand what is going on, I just rebased the PR (:

- Add a top margin to avoid hiding indicators behind a notch
- Add an option in gsettings to revert to the previous behavior
- Get the margin in pixels from the device configuration
@Flohack74
Copy link
Member

Nice, we need to clean it a bit, but I definitely want this for 2 distinct phone models now ;)

@JamiKettunen
Copy link

@Flohack74 Is this "confirmed" to be the way we want to go forward with notch integration on Unity 8 / Lomiri shell? I wouldn't mind making a parallel MR for focal on https://gitlab.com/ubports/development/core/lomiri myself ^^

@JamiKettunen
Copy link

JamiKettunen commented Oct 5, 2022

With 20.04 (and future) in mind we should refactor plugins/Utils/deviceconfigparser.* changes and get a libdeviceinfo replacement as that is also available on 16.04 already while the deviceconfigparser is gone in focal
Ignore me, while libdeviceinfo is also on 16.04 we probably don't want to start integrating it into the shell if it already wasn't before, so this might just have to be done differently on 20.04 and it doesn't seem there's backwards compatability for the old deviceconfigparser way so with migration to focal existing configuration from xenial will have to be migrated to deviceinfo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants