Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ACL->authz migration script for "[ project, program ]" ACLs #284

Merged
merged 2 commits into from
Jul 9, 2020

Conversation

paulineribeyre
Copy link
Contributor

@paulineribeyre paulineribeyre commented Jul 9, 2020

Fix migration script:

  • For ACL ['PROG', 'PROJ'] we get path = /programs/PROG/projects/PROJ
  • For ACL ['PROJ', 'PROG'] we get EnvironmentError: program or project PROG does not exist

The script will also now raise an error for ACL [<project that exists>, <program that doesn't exist>] instead of just using the project to generate the path

Also, sqlalchemy-utils 0.36.8 is breaking indexd: FATAL: database "indexd_user" does not exist
so limiting to working versions sqlalchemy-utils>=0.33.11,<=0.36.6
see kvesteri/sqlalchemy-utils#462

Bug Fixes

  • Fix ACL->authz migration script for "[ project, program ]" ACLs

Dependency updates

  • Add sqlalchemy-utils upper bound "<=0.36.6" in addition to ">=0.33.11"

@github-actions
Copy link

github-actions bot commented Jul 9, 2020

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@paulineribeyre paulineribeyre merged commit 7a14af3 into master Jul 9, 2020
@paulineribeyre paulineribeyre deleted the paulineribeyre-patch-1 branch July 9, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants