Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change design of team cards (code) #54

Open
EinarBalan opened this issue May 9, 2021 · 1 comment
Open

Change design of team cards (code) #54

EinarBalan opened this issue May 9, 2021 · 1 comment
Labels
blocked this issue is waiting on something else medium reserved

Comments

@EinarBalan
Copy link
Collaborator

This issue stems from #48.

For convenience, here's what I wrote there that led to me creating this new issue:

Honestly, not totally in love with how the card grid is looking with the addition of studio, would it be possible to mess around with the design and try to improve it? Some possible options that come to mind:

  1. Make all cards the same height regardless of content within them.
  2. Instead of having a 3x3 grid, revert back to the same card sizing as we had before, but just include 4 cards on the top and 5 on the bottom. To accomplish this, you would likely have to get rid of the grid and manually place the cards rather than generate them as we are currently (which is not preferred).
  3. Get rid of the grid entirely and completely redesign the team section to be more accommodating to 9 cards.
    Regardless of what you choose, this is probably beyond the scope of this PR, so don't worry about it for now. I'll make a new issue for this.

You can take any of the approaches I listed above (or even a different approach if you think it would be better). However, I do recommend first mocking up your design changes in Figma and messaging me to ask for my thoughts before you start implementing anything in order to save some time.

@doubleiis02 doubleiis02 changed the title Change design of team cards Change design of team cards (code) Jan 16, 2022
@doubleiis02 doubleiis02 added the blocked this issue is waiting on something else label Jan 16, 2022
@doubleiis02
Copy link
Contributor

blocked until #88 is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked this issue is waiting on something else medium reserved
Projects
None yet
Development

No branches or pull requests

2 participants