Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

95 minor update adjust styling of lessonside to avoid scrolling #121

Conversation

angoway
Copy link
Collaborator

@angoway angoway commented Oct 23, 2024

minor update: adjusted lessonside styling to avoid scrolling.

Summary

Closes #95
Made some changes in:

  1. LessonSide.scss (changing spacing, padding, and container width)
  2. LessonSide.tsx (turtle-and-levels-container so that the turtle could be centered)
  3. ExerciseSide.scss (changed container width to take up 55vw)
  4. _vars.scss (changed font sizes)

@angoway angoway requested a review from SanjnaT41756 October 23, 2024 21:30
@angoway angoway linked an issue Oct 23, 2024 that may be closed by this pull request
1 task
Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for pen-pals ready!

Name Link
🔨 Latest commit dd522bb
🔍 Latest deploy log https://app.netlify.com/sites/pen-pals/deploys/672533767e38b700088830f8
😎 Deploy Preview https://deploy-preview-121--pen-pals.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SanjnaT41756
Copy link
Contributor

Hi Amanda great work so far! There are a few changes I would like to request, however. Would you be able to make the footer be at the bottom of the page? I know it wasn't like that before, but I think it would look nicer if the footer was touching the bottom. Also, would you be able to make the text a bit bigger for readability purposes? Lmk if you have any concerns!
image

…bottom, and made it so that the turtle and level selector stay on the same place in the container, no matter if the lesson text changes
@angoway
Copy link
Collaborator Author

angoway commented Oct 31, 2024

  1. Adjusted text size and spacing in vars.scss and LessonSide.scss
  2. Footer is now at the bottom of the container (removed padding in Footer.scss)
  3. Turtle and lesson selector stay in one spot on the container (do not move depending on length of lesson's text)

@SanjnaT41756 SanjnaT41756 merged commit 4617b51 into main Nov 1, 2024
6 checks passed
@SanjnaT41756 SanjnaT41756 deleted the 95-minor-update-adjust-styling-of-lessonside-to-avoid-scrolling branch November 1, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐾 Minor Update: Adjust styling of LessonSide to avoid scrolling
2 participants