-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sfitz add mosdepth quantize #88
Open
sorelfitzgibbon
wants to merge
47
commits into
main
Choose a base branch
from
sfitz-add-mosdepth-quantize
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 44 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
1e093a2
add mosdepth and index file and change path name
sorelfitzgibbon 5375b19
update resources
sorelfitzgibbon 7ff81eb
update version in metadata
sorelfitzgibbon 9a971e5
fix path to bam in tuple
sorelfitzgibbon fcd824b
update changelog
sorelfitzgibbon 91136c9
resource adjustments
sorelfitzgibbon 5e345c4
adjust log info
sorelfitzgibbon 8beaf43
change process names
sorelfitzgibbon acbb0fd
rename bamqc_outformat to bamqc_output_format
sorelfitzgibbon 668d83c
rename bamqc_outformat to bamqc_output_format
sorelfitzgibbon b178e75
remove fastqc as default
sorelfitzgibbon b59503d
fix CollectWgsMetrics params bug
sorelfitzgibbon c3d525f
add mosdepth and index file and change path name
sorelfitzgibbon b97d512
update changelog
sorelfitzgibbon 7d536cd
Merge branch 'main' of github.com:uclahs-cds/pipeline-generate-SQC-BA…
sorelfitzgibbon f90c11f
fix left over merge lines M64.config
sorelfitzgibbon 35f5aac
change template mosdepth fast to false
sorelfitzgibbon 4975b4c
add quantize to resource configs
sorelfitzgibbon cad71c7
add quantize to resource configs
sorelfitzgibbon 2f89689
update schema
sorelfitzgibbon 80b352e
add quantize
sorelfitzgibbon 76fcb40
add quantize
sorelfitzgibbon 8a254cc
Merge branch 'sfitz-add-mosdepth' into sfitz-add-mosdepth-quantize
sorelfitzgibbon 1aca7bc
add mosdepth to nftest
sorelfitzgibbon 8ea75a1
update nftest mosdepth slow
sorelfitzgibbon 81ee369
change algorithm option coverage to windows
sorelfitzgibbon 7c0812b
update README
sorelfitzgibbon 82bdfe9
merge in coverage to windows
sorelfitzgibbon 1715272
require quantize cutoffs
sorelfitzgibbon 51fdb1e
output filename dash and add to test config
sorelfitzgibbon 3f11738
update changelog
sorelfitzgibbon 313b079
add mosdepth per-base output
sorelfitzgibbon ce597f6
update submodules
sorelfitzgibbon 55679d0
merge main
sorelfitzgibbon 8c976ab
move gitignore lines to local only
sorelfitzgibbon 8aa3634
add nftest config files
sorelfitzgibbon 7462538
finish main merge
sorelfitzgibbon cab90a8
alorithm name
sorelfitzgibbon 4fe2727
add quantize to nftest and update config names
sorelfitzgibbon 027bad9
typo
sorelfitzgibbon 7e48841
update readme
sorelfitzgibbon 9527f7f
fix duplicate keys
sorelfitzgibbon 563775d
fix nftest
sorelfitzgibbon 5fb7a72
reorganize nftest.yml
sorelfitzgibbon b5be444
fix minor issues
sorelfitzgibbon 4514bd4
fix output filenames, mosdepth windows too
sorelfitzgibbon 20a6d52
Merge remote-tracking branch 'origin' into sfitz-add-mosdepth-quantize
sorelfitzgibbon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -81,7 +81,3 @@ work/ | |
*.tar | ||
*.zip | ||
|
||
# Other | ||
test/* | ||
test/*/* | ||
slurm-*.out |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (non-blocking): Is there a downside to enabling the use of the fast algorithm by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is a difficult decision. Not using fast mode gives more "correct" results. Fast mode ignores paired read overlaps and CIGAR strings (thus indels wrt ref). Ignoring the paired read overlap is the bigger issue, especially for samples with small insert sizes (wrt read length). This is noted in the README. The time difference isn't clear as I haven't benchmarked more than a few samples and not directly on scratch. It's enough that the
mosdepth
author recommends fast mode for most use-cases (I assume non-small insert cases). We currently have fast modetrue
by default for the regularmosdepth
coverage calculation, so we should probably change one or the other to make them consistent.