Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align drafts of Endurant and Perdurant #2

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Align drafts of Endurant and Perdurant #2

merged 1 commit into from
Feb 2, 2024

Conversation

ajnelson-nist
Copy link
Contributor

No description provided.

@ajnelson-nist
Align drafts of Endurant and Perdurant
d28d05a 
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
plbt5
plbt5 reviewed Feb 2, 2024
View reviewed changes
Copy link
Contributor

@plbt5 plbt5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see issues here. You subclassed from the taxo of gufo Individuals, and followed that pattern consistently.
You did not (yet) instantiate / rdf:type'd from the taxo of gufo Types, which is the complementary pattern that one could adopt on top of it.

@plbt5 plbt5 merged commit f126cfb into main Feb 2, 2024
1 check passed
@plbt5 plbt5 deleted the align_endurant_perdurant branch February 2, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plbt5 plbt5 plbt5 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajnelson-nist @plbt5