-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breadcrumb link disappears on CanDeactivate guard check when the route has a resolver. Breadcrumb loads before the resolver promise completes. #129
Comments
Hello 👋 @udayvunnam |
Hi, @udayvunnam , |
@hugo-azevedo currently I am occupied with my work, I can work on this in the next two weeks. PR is always welcome if you wish to contribute. |
^^ @hugo-azevedo please check #111 (comment) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
not stale |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@udayvunnam - The feature is failing in another scenario i.e. when the route has a resolver. Breadcrumb loads before the resolver promise completes. Also, I saw you have added a new filter for GuardChecksEnd in the breadcrumb service. This is breaking the earlier guard check fix which was added. Now even if "cancel" button is clicked, the breadcrumb link disappears.
Instead of the below - line 68
.pipe(filter((event) => event instanceof GuardsCheckEnd))
replace with NavigationEnd
.pipe(filter((event) => event instanceof NavigationEnd))
remove "&& event.shouldActivate" from line 76
This should resolve both GuardCheck and Resolver issues.
Originally posted by @nakash2050 in #111 (comment)
The text was updated successfully, but these errors were encountered: