Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumb link disappears on CanDeactivate guard check when the route has a resolver. Breadcrumb loads before the resolver promise completes. #129

Closed
udayvunnam opened this issue Feb 9, 2022 · 9 comments
Labels
bug Something isn't working help wanted Extra attention is needed no-issue-activity

Comments

@udayvunnam
Copy link
Owner

@udayvunnam - The feature is failing in another scenario i.e. when the route has a resolver. Breadcrumb loads before the resolver promise completes. Also, I saw you have added a new filter for GuardChecksEnd in the breadcrumb service. This is breaking the earlier guard check fix which was added. Now even if "cancel" button is clicked, the breadcrumb link disappears.

Instead of the below - line 68
.pipe(filter((event) => event instanceof GuardsCheckEnd))

replace with NavigationEnd
.pipe(filter((event) => event instanceof NavigationEnd))

remove "&& event.shouldActivate" from line 76

This should resolve both GuardCheck and Resolver issues.

Originally posted by @nakash2050 in #111 (comment)

@github-actions
Copy link

github-actions bot commented Feb 9, 2022

Hello 👋 @udayvunnam
Thank you for raising an issue. We will investigate into the issue and get back to you as soon as possible. Please make sure you have given us as much context as possible.
Feel free to raise a PR if you can fix the issue. Check the local development guide

@udayvunnam udayvunnam changed the title @udayvunnam - The feature is failing in another scenario i.e. when the route has a resolver. Breadcrumb loads before the resolver promise completes. Also, I saw you have added a new filter for GuardChecksEnd in the breadcrumb service. This is breaking the earlier guard check fix which was added. Now even if "cancel" button is clicked, the breadcrumb link disappears. Breadcrumb link disappears on CanDeactivate guard check when the route has a resolver. Breadcrumb loads before the resolver promise completes. Feb 9, 2022
@udayvunnam udayvunnam added bug Something isn't working help wanted Extra attention is needed labels Feb 9, 2022
@hugo-azevedo
Copy link

Hi, @udayvunnam ,
I too am seeing this issue.
Would it be possible to get a timeframe for this fix?
Thanks in advance for your time and attention.

@udayvunnam
Copy link
Owner Author

@hugo-azevedo currently I am occupied with my work, I can work on this in the next two weeks. PR is always welcome if you wish to contribute.

@udayvunnam
Copy link
Owner Author

udayvunnam commented Mar 27, 2022

^^ @hugo-azevedo please check #111 (comment)

@stale
Copy link

stale bot commented Jul 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 30, 2022
@udayvunnam udayvunnam removed the wontfix This will not be worked on label Aug 3, 2022
@udayvunnam
Copy link
Owner Author

not stale

@stale
Copy link

stale bot commented Dec 3, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 3, 2022
@stale stale bot closed this as completed Apr 7, 2023
@udayvunnam udayvunnam reopened this May 27, 2023
@stale stale bot removed the wontfix This will not be worked on label May 27, 2023
@stale
Copy link

stale bot commented Oct 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 15, 2023
@stale stale bot closed this as completed Mar 17, 2024
@udayvunnam udayvunnam reopened this Mar 17, 2024
@udayvunnam udayvunnam removed the wontfix This will not be worked on label Mar 17, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed no-issue-activity
Projects
None yet
Development

No branches or pull requests

2 participants