Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate breadcrumbs on Angular 17 #179

Closed
HammamBM opened this issue Nov 14, 2023 · 6 comments
Closed

Duplicate breadcrumbs on Angular 17 #179

HammamBM opened this issue Nov 14, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@HammamBM
Copy link

🐞 Bug report

Description

I update to Angular 17 with legacy-peer-deps. It compiles and shows breadcrumbs, but they are duplicated in some sites with a last empty breadcrumb.

🔬 Minimal Reproduction

Nested lazy routes shows duplicated home route and a last chevron with empty label. First and second images are the route setup: app routes and children lazy routes. Third image is the UI and the last one is the console.log of the breadcrumbs
image
image
image
image

This started to happen after update to v17.

💻Your Environment

Angular Version:


Angular CLI: 17.0.0
Node: 18.16.1
Package Manager: npm 9.5.1
OS: win32 x64

Angular: 17.0.2
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                              Version
--------------------------------------------------------------
@angular-devkit/architect            0.1700.0
@angular-devkit/build-angular        17.0.0
@angular-devkit/core                 17.0.0
@angular-devkit/schematics           17.0.0
@angular/cdk                         17.0.0
@angular/cli                         17.0.0
@angular/material                    17.0.0
@angular/material-date-fns-adapter   17.0.0
@schematics/angular                  17.0.0
rxjs                                 7.8.1
typescript                           5.2.2
zone.js                              0.14.2

@HammamBM HammamBM added the bug Something isn't working label Nov 14, 2023
Copy link

Hello 👋 @HammamBM
Thank you for raising an issue. We will investigate into the issue and get back to you as soon as possible. Please make sure you have given us as much context as possible.
Feel free to raise a PR if you can fix the issue. Check the local development guide

@softworckx
Copy link

softworckx commented Nov 16, 2023

Same issue here. Just upgraded Angular from 16 to 17.0.3:
Before:
image

After:
image

Any news yet?

EDIT: if I downgrade xng-breadcrumb from 10.0.1 -> 10.0.0 it works fine, also in Angular 17.

@udayvunnam
Copy link
Owner

@HammamBM please use 10.0.0 as mentioned by @softworckx above. The last merged PR #177 may have caused this. I will verify and provide support with Angular v17

@HammamBM
Copy link
Author

@HammamBM please use 10.0.0 as mentioned by @softworckx above. The last merged PR #177 may have caused this. I will verify and provide support with Angular v17

That is true. Going back to 10.0.0 works perfectly. Thank you so much. Shall I close the issue?

@cskiwi cskiwi mentioned this issue Nov 20, 2023
3 tasks
@softworckx
Copy link

@udayvunnam Have you already find the time to code review the open PR on this bug?

@udayvunnam
Copy link
Owner

@softworckx @HammamBM the fix is published on `xng-breadcrumb@10.0.21 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants