feat: Updates supported resource types (2) #857
Conversation
WalkthroughThis pull request updates the Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/supported_resource_types.rs(3 hunks)
🧰 Additional context used
🪛 GitHub Actions: Test
src/supported_resource_types.rs
[error] 1-1109: Large array defined as const. The array contains 1107 elements which is considered too large for a const definition. Consider using 'static' instead of 'const' for this array.
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Automerge CI
🔇 Additional comments (1)
src/supported_resource_types.rs (1)
52-52: LGTM! New resource types added correctly.The following AWS resource types have been added in alphabetical order:
- AWS::AppConfig::Deployment
- AWS::CustomerProfiles::EventTrigger
Let's verify that these are valid AWS CloudFormation resource types:
Also applies to: 260-260
✅ Verification successful
Verification successful: Both resource types are valid AWS CloudFormation resources
- ✓ AWS::AppConfig::Deployment
- ✓ AWS::CustomerProfiles::EventTrigger
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the new resource types are valid AWS CloudFormation resource types # Test: Check AWS documentation for these resource types curl -s "https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-appconfig-deployment.html" -o /dev/null -w "%{http_code}\n" curl -s "https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-customerprofiles-eventtrigger.html" -o /dev/null -w "%{http_code}\n"Length of output: 306
| @@ -1,4 +1,4 @@ | |||
| pub const SUPPORTED_RESOURCE_TYPES: [&str; 1105] = [ | |||
| pub const SUPPORTED_RESOURCE_TYPES: [&str; 1107] = [ | |||
There was a problem hiding this comment.
Fix the pipeline failure by using 'static' instead of 'const'.
The pipeline indicates that using const for large arrays (1107 elements) may cause performance issues.
Apply this diff to resolve the pipeline failure:
-pub const SUPPORTED_RESOURCE_TYPES: [&str; 1107] = [
+pub static SUPPORTED_RESOURCE_TYPES: [&str; 1107] = [📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| pub const SUPPORTED_RESOURCE_TYPES: [&str; 1107] = [ | |
| pub static SUPPORTED_RESOURCE_TYPES: [&str; 1107] = [ |
🧰 Tools
🪛 GitHub Actions: Test
[error] 1-1109: Large array defined as const. The array contains 1107 elements which is considered too large for a const definition. Consider using 'static' instead of 'const' for this array.
udondan
force-pushed
the
resource-type-updates
branch
from
153fbdd to
c076de2
Compare
Added resources:
Summary by CodeRabbit