check for 'users:read' scope in scopes before making 'users.info' call #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hassox
reviewed
Dec 1, 2017
| else | ||
| set_errors!(conn, [error(user["error"], user["error"])]) | ||
| case "users:read" in scopes do | ||
| false -> conn |
There was a problem hiding this comment.
Do we need to set an error here? I'm not sure how the rest of the module would react to not having a slack user on the conn when it tries to construct the auth struct.
|
I think this will break both the credentials and info calls if there is no user present. |
|
@prashanthsadasivan / @hassox any updates here? |
|
@prashanthsadasivan should probably just close this since #21 is merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17