Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address warnings in dockerfiles and composer files #7

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

OyvindLGjesdal
Copy link

@OyvindLGjesdal OyvindLGjesdal commented Oct 9, 2024

Phases MP MM MB MR JM Total
ETA 0 0 0 0 0 0
Developing 0 0 0 0 0 0
Review 0 0 0 0 0 0
Total - - - - - 0
ETA est. 0
ETA cust. - - - - - 0

Problem description

Docker build gives

2 warnings found (use docker --debug to expand):
 - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 27)
 - JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals (line 31)

and for Dockerfile.dist

 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 7)

I am not sure how to convert the args in the CMD in Dockerfile to an array, since it also contains redirect of output, so I skipped it.

For docker compose files I see

`version` is obsolete

Reported issues

Not-reported issues

Analysis

Problems

@kosarko kosarko self-assigned this Nov 6, 2024
@kosarko kosarko merged commit 7899a88 into ufal:clarin-v7 Nov 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants