Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight sections on course hover #50

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

chrisnicollo
Copy link

Addresses part of #29.

Make it so when courses are hovered on the left, sections in the middle are highlighted. I can add functionality to highlight sections on section hover in this branch later using a similar pattern.

@chrisnicollo chrisnicollo marked this pull request as draft September 19, 2023 22:49
@chrisnicollo
Copy link
Author

Also I converted SectionDisplay to a functional component

@chrisnicollo chrisnicollo marked this pull request as ready for review September 28, 2023 22:37
@RobertConde
Copy link
Collaborator

This is great work! Let me know when you want me to actually review it for a merge. :))

@RobertConde RobertConde linked an issue Sep 29, 2023 that may be closed by this pull request
@RobertConde
Copy link
Collaborator

OMG I just checked out your changes.

I am sooooo pleased!!! It's so responsive, I love it!!!!

@RobertConde
Copy link
Collaborator

Only one bug. When I move from one section to another in the middle column all of the sections don't stay highlighted. Maybe it was a bug introduced in the debouncing.
image

@RobertConde RobertConde self-requested a review September 29, 2023 03:32
Copy link
Collaborator

@RobertConde RobertConde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See bug above.

@chrisnicollo
Copy link
Author

I've tried to use redux for message dispatching on this branch, but I've no clue if the code works because locally I'm getting dependency issues where redux cannot resolve references to react

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Course / section hover color-change
2 participants