Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pr reviewing guide #5

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Conversation

PythiaUF
Copy link
Contributor

This PR adds a guide for how to review PRs on GitHub. This is pretty much a direct copy of the guide on my website, notes and all.

docs/club/resources/pr_review.md Outdated Show resolved Hide resolved
@danielwildsmith
Copy link
Collaborator

LGTM thanks @PythiaUF

@danielwildsmith danielwildsmith merged commit 7edb1b3 into ufosc:main Sep 10, 2024
2 checks passed
@PythiaUF PythiaUF deleted the pr-review branch September 10, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants