Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of sfcsub.F in global_cycle program #933

Closed
GeorgeGayno-NOAA opened this issue Apr 24, 2024 · 2 comments · Fixed by #950
Closed

Update version of sfcsub.F in global_cycle program #933

GeorgeGayno-NOAA opened this issue Apr 24, 2024 · 2 comments · Fixed by #950
Assignees
Labels
maintenance Basic upkeep

Comments

@GeorgeGayno-NOAA
Copy link
Collaborator

GeorgeGayno-NOAA commented Apr 24, 2024

A bug was found in the sfcsub.F program:

ufs-community/ccpp-physics#199
NOAA-EMC/global-workflow#2498

To implement this bug fix in global_cycle, the program will first need to use the latest version in the ccpp-physics.

https://github.com/ufs-community/ccpp-physics/commits/ufs/dev/physics/Interstitials/UFS_SCM_NEPTUNE/sfcsub.F

@GeorgeGayno-NOAA GeorgeGayno-NOAA added the maintenance Basic upkeep label Apr 24, 2024
@GeorgeGayno-NOAA GeorgeGayno-NOAA self-assigned this Apr 24, 2024
GeorgeGayno-NOAA added a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue Apr 24, 2024
@GeorgeGayno-NOAA
Copy link
Collaborator Author

Using 30e17b2, all global_cycle regression tests passed on Hera.

@GeorgeGayno-NOAA
Copy link
Collaborator Author

Will wait until the bug in sfcsub.F is merged to the ccpp repository before issuing a UFS_UTILS PR.

ufs-community/ccpp-physics#199

GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue May 21, 2024
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue May 21, 2024
GeorgeGayno-NOAA pushed a commit to GeorgeGayno-NOAA/UFS_UTILS that referenced this issue May 24, 2024
GeorgeGayno-NOAA added a commit that referenced this issue May 28, 2024
Point to latest version of sfcsub.F from the ccpp-physics
repository. This version contains a bug fix in the interpolation
of GLDAS data.  This sfcsub.F version also updates soil color.
This field is not yet processed by global_cycle, so add a dummy
soil color argument.

Fixes #933.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Basic upkeep
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant