Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global_cycle - Update version of sfcsub.F #950

Merged
merged 4 commits into from
May 28, 2024

Conversation

GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA commented May 21, 2024

DESCRIPTION OF CHANGES:

The sfcsub.F routine was recently bug fixed (the interpolation of GLDAS data was using the wrong land mask). The bug did not affect results. It just resulted in very slow run times when running with a fractional grid at C768. The global_cycle program points to the sfcsub.F in the ccpp-physics repository. Update the submodule to point to the latest hash.

TESTS CONDUCTED:

If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.

All tests done using 2879250.

  • Compile branch on all Tier 1 machines using Intel (Orion, Jet, Hera, Hercules and WCOSS2).
  • Compile branch on Hera using GNU.
  • Compile branch in 'Debug' mode on WCOSS2.
  • Run unit tests locally on any Tier 1 machine.
  • Run relevant consistency tests locally on all Tier 1 machines. All global_cycle tests passed as expected.

Additional tests performed:

A test was done using the global workflow: NOAA-EMC/global-workflow#2498 (comment)

DEPENDENCIES:

The sfcsub.F module is part of the ccpp-physics. This fix was committed at:
ufs-community/ccpp-physics#205

DOCUMENTATION:

N/A

ISSUE:

Fixes #933.
Related to: NOAA-EMC/global-workflow#2498

@GeorgeGayno-NOAA
Copy link
Collaborator Author

@WalterKolczynski-NOAA - do you want to run a quick test of my branch in the workflow?

@GeorgeGayno-NOAA GeorgeGayno-NOAA marked this pull request as ready for review May 22, 2024 13:15
@GeorgeGayno-NOAA
Copy link
Collaborator Author

@sanatcumar - since you now are familiar with the sfcsub code, I would like to add you as a reviewer.

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit c6e032b into ufs-community:develop May 28, 2024
4 checks passed
@GeorgeGayno-NOAA GeorgeGayno-NOAA deleted the new_sfcsub branch July 15, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update version of sfcsub.F in global_cycle program
2 participants