global_cycle - Update version of sfcsub.F #950
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
The sfcsub.F routine was recently bug fixed (the interpolation of GLDAS data was using the wrong land mask). The bug did not affect results. It just resulted in very slow run times when running with a fractional grid at C768. The
global_cycle
program points to the sfcsub.F in the ccpp-physics repository. Update the submodule to point to the latest hash.TESTS CONDUCTED:
If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.
All tests done using 2879250.
global_cycle
tests passed as expected.Additional tests performed:
A test was done using the global workflow: NOAA-EMC/global-workflow#2498 (comment)
DEPENDENCIES:
The sfcsub.F module is part of the ccpp-physics. This fix was committed at:
ufs-community/ccpp-physics#205
DOCUMENTATION:
N/A
ISSUE:
Fixes #933.
Related to: NOAA-EMC/global-workflow#2498