-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add forecast day output for CICE via timestep stream #2437
Add forecast day output for CICE via timestep stream #2437
Conversation
@junwang-noaa Ice history baselines have been added and tests are as expected on hercules. Please let me know if there is anything more to resolve |
on-behalf-of @ufs-community <ecc.platform@noaa.gov>
@jkbk2004 A new bl_date is needed for this PR as the history/iceh_06h changed in addition to the newly added history/iceh daily history. Apologies for my mistake as I forgot about the changed iceh_06h file Please let me know if I can help correct. Only the CICE history/ice*nc baseline files change between these and the previous baseline date |
The following should fix the problem created here:
|
OK! I will update bl_date to 20241001. |
Understood, we'll move current 0909 to 1001 and regenerate the two gfs cases for 0909 off develop |
Adding a note that the 0909 bl date in the Hera and Gaea logs are for the BLs that were later moved to 20241001 before 0909 was restored. |
Could you do a sanity check on Hera with develop branch and the 0909 baselines to make sure you made the correct adjustments? |
I did a sanity check on WCOSS2 with the 0909->1001 change with the develop branch and the 0909 baselines and all tests that WCOSS2 runs, passed. |
Sanity check testing finally finished for the affected tests, yes 0909 should be good to go. I'm going to go ahead and merge this PR. |
Derecho will be skipped this PR due to allocation. |
Commit Queue Requirements:
Description:
To have time-averaged CICE output over a forecast day, we use a timestep stream, like
for a CICE timestep of 720s. The other stream options are calendar-based and "daily" output files start over at 00Z (like calendar days), without the desired time_bounds if the forecast starts after 00Z. As it may be better for workflow not to need extra post-processing steps to have daily forecast output (NOAA-EMC/global-workflow#2674), model outputs this stream directly.
icefields_nml section in tests/parm/ice_in.IN has been modified to 1) add all of the hourly stream variables to the timestep stream as well and 2) remove
blkmask
as not needed and fails decomposition tests by constructionDaily ice history files are added to gfsv17 baselines to maintain testing of a forecast day output stream requested by global-workflow. All non-ice history baselines match b4b. Ice history baselines reproduce themselves.
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: