Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forecast day output for CICE via timestep stream #2437

Merged

Conversation

NickSzapiro-NOAA
Copy link
Collaborator

@NickSzapiro-NOAA NickSzapiro-NOAA commented Sep 11, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

To have time-averaged CICE output over a forecast day, we use a timestep stream, like

histfreq            = '1'
histfreq_n          = 120
hist_avg            = .true.

for a CICE timestep of 720s. The other stream options are calendar-based and "daily" output files start over at 00Z (like calendar days), without the desired time_bounds if the forecast starts after 00Z. As it may be better for workflow not to need extra post-processing steps to have daily forecast output (NOAA-EMC/global-workflow#2674), model outputs this stream directly.

icefields_nml section in tests/parm/ice_in.IN has been modified to 1) add all of the hourly stream variables to the timestep stream as well and 2) remove blkmask as not needed and fails decomposition tests by construction

Daily ice history files are added to gfsv17 baselines to maintain testing of a forecast day output stream requested by global-workflow. All non-ice history baselines match b4b. Ice history baselines reproduce themselves.

Commit Message:

* UFSWM - Add forecast day output for CICE via timestep stream

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

  • None

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@NickSzapiro-NOAA NickSzapiro-NOAA added the Baseline Updates Current baselines will be updated. label Sep 25, 2024
@NickSzapiro-NOAA
Copy link
Collaborator Author

@junwang-noaa Ice history baselines have been added and tests are as expected on hercules. Please let me know if there is anything more to resolve

junwang-noaa
junwang-noaa previously approved these changes Sep 30, 2024
@jkbk2004 jkbk2004 mentioned this pull request Sep 30, 2024
14 tasks
@jkbk2004 jkbk2004 added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Oct 2, 2024
@zach1221 zach1221 added jenkins-ort run ORT testing and removed jenkins-ort run ORT testing labels Oct 2, 2024
 on-behalf-of @ufs-community <ecc.platform@noaa.gov>
@NickSzapiro-NOAA
Copy link
Collaborator Author

NickSzapiro-NOAA commented Oct 3, 2024

@jkbk2004 A new bl_date is needed for this PR as the history/iceh_06h changed in addition to the newly added history/iceh daily history. Apologies for my mistake as I forgot about the changed iceh_06h file

Please let me know if I can help correct. Only the CICE history/ice*nc baseline files change between these and the previous baseline date

@BrianCurtis-NOAA
Copy link
Collaborator

The following should fix the problem created here:

  • copy baselines from 0909 to a new bl date (were we using 1001 prior to the revert?)
  • run develop branch on the test_changes.list files and copy those to 0909

@jkbk2004
Copy link
Collaborator

jkbk2004 commented Oct 3, 2024

OK! I will update bl_date to 20241001.

@FernandoAndrade-NOAA
Copy link
Collaborator

FernandoAndrade-NOAA commented Oct 3, 2024

The following should fix the problem created here:

* copy baselines from 0909 to a new bl date (were we using 1001 prior to the revert?)

* run develop branch on the test_changes.list files and copy those to 0909

Understood, we'll move current 0909 to 1001 and regenerate the two gfs cases for 0909 off develop

@FernandoAndrade-NOAA
Copy link
Collaborator

Adding a note that the 0909 bl date in the Hera and Gaea logs are for the BLs that were later moved to 20241001 before 0909 was restored.

@BrianCurtis-NOAA
Copy link
Collaborator

Adding a note that the 0909 bl date in the Hera and Gaea logs are for the BLs that were later moved to 20241001 before 0909 was restored.

Could you do a sanity check on Hera with develop branch and the 0909 baselines to make sure you made the correct adjustments?

@BrianCurtis-NOAA
Copy link
Collaborator

I did a sanity check on WCOSS2 with the 0909->1001 change with the develop branch and the 0909 baselines and all tests that WCOSS2 runs, passed.

@FernandoAndrade-NOAA
Copy link
Collaborator

Adding a note that the 0909 bl date in the Hera and Gaea logs are for the BLs that were later moved to 20241001 before 0909 was restored.

Could you do a sanity check on Hera with develop branch and the 0909 baselines to make sure you made the correct adjustments?

Sanity check testing finally finished for the affected tests, yes 0909 should be good to go. I'm going to go ahead and merge this PR.

@FernandoAndrade-NOAA
Copy link
Collaborator

Derecho will be skipped this PR due to allocation.

@FernandoAndrade-NOAA FernandoAndrade-NOAA merged commit e3750c2 into ufs-community:develop Oct 5, 2024
3 checks passed
@NickSzapiro-NOAA NickSzapiro-NOAA deleted the ice_24hrOutput branch October 7, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants