-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ninth reconciliation PR from production/RRFS.v1 + Add CCPP host variable to track initialization of GFS_phys_time_vary (#2544) + develop of WW3 up to 2024-01-11 to dev/ufs-weather-model #1342 (#2549) #2532
base: develop
Are you sure you want to change the base?
Conversation
…nd therefore isn't commit-able
@jkbk2004 I combined #2544 into this one because neither changes baselines and I thought it would lighten the merge queue load a bit. Please let me know if you'd like this reversed. Also, I noticed on your updated merge queue that you'd like to combine #2549 as well. I'm happy to do this. Please let me know if you'd like me to do that. |
Hi @grantfirl, yes we'd like to bring #2549 into this PR as well , thank you! |
@jkbk2004 @FernandoAndrade-NOAA OK, the PRs have been combined and should be ready to test. They have each been tested independently and one can still look at the RT logs from the original PRs if necessary. The RT log left in PR branch right now is only valid for the pre-test that I did for the original, un-combined PR, although it will get re-written with the final tests before merge. |
@jkbk2004 @FernandoAndrade-NOAA Are the WW3 inputs synced to Hera? |
They should be available on Hera at |
@FernandoAndrade-NOAA can you make the changes mentioned in NOAA-EMC/WW3#1342 (comment) to this PR? |
@jkbk2004 and @FernandoAndrade-NOAA you'll need to change the date on the hera input-data-20240501 directory for the WW3_input_data as well. This is still showing as 20240111 |
@BrianCurtis-NOAA do you mean to update the date of /scratch2/NAGAPE/epic/UFS-WM_RT/NEMSfv3gfs/input-data-20240501 ? In that case, we need to keep input-data-20240501 and create new input directory to add WW3_input_data_20240111. There are a few WW3_input_data_* already in input-data-20240501: we are using WW3_input_data_20240214. Adding WW3_input_data_20240111 under input-data-20240501 looks ok. @JessicaMeixner-NOAA any comment? |
@jkbk2004 @FernandoAndrade-NOAA Actually, looking through the WW3_input_data_20240111 directory it seems that you've synced over directories that are completely irrelevant to the .NC files that are needed for regression testing. I would assume we don't need (@JessicaMeixner-NOAA can correct me if i'm wrong)
@jkbk2004 I mean in rt.sh we renamed WW3_input_data_20240111 to WW3_input_data_20250114 and I was asking for EPIC to make sure that on Hera, that directory was also renamed to match that new date. I did a test sync and it still shows WW3_input_data_20240111 in /scratch2/NAGAPE/epic/UFS-WM_RT/NEMSfv3gfs/input-data-20240501 |
@BrianCurtis-NOAA - good catch about the extra files. However, the createmoddefs directory should be kept, the workdir should be removed. |
Thanks for the clarification! |
@JessicaMeixner-NOAA in createmoddefs, do we need the |
@BrianCurtis-NOAA - thanks again for finding this, no we do not need either of those directories. |
Testing is complete, I'll leave a note in subcomponents to continue with merging. |
Commit Queue Requirements:
Description:
This PR combines 3 into 1.
The first is identical to #2405 and #2428 and is the work of @JiliDong-NOAA
The second is #2544: The set of PRs listed belows adds support for multiple physics instances running the GFS_phys_time_vary scheme. No changes in the ufs-weather-model repository itself. See associated PRs below for more information.
The third is #2549: Merge develop of WW3 up to 2024-01-11 to dev/ufs-weather-model
Commit Message:
Priority:
Git Tracking
UFSWM:
Closes (replaces) NCAR/ccpp-physics#1000
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
New input data: New WW3 Input data currently located on hera at: /scratch1/NCEPDEV/climate/Jessica.Meixner/PR_WW3/UFSPRww3Jan11/WW3_input_data_20240111
Library Changes/Upgrades:
Testing Log: