Skip to content

Commit

Permalink
- Changes to asking / tabling / answering member parties shown in sea…
Browse files Browse the repository at this point in the history
…rch results

- Fixes to several other search result partials involving multiple names
  • Loading branch information
j-corry committed Aug 28, 2024
1 parent c7c8ca8 commit 401dec2
Show file tree
Hide file tree
Showing 13 changed files with 25 additions and 19 deletions.
4 changes: 4 additions & 0 deletions app/models/content_object.rb
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,10 @@ def asking_member_party
get_first_from('askingMemberParty_ses')
end

def asking_member_parties
get_all_from('askingMemberParty_ses')
end

def lead_member
get_first_from('leadMember_ses')
end
Expand Down
8 changes: 8 additions & 0 deletions app/models/question.rb
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ def tabling_member_party
get_first_from('tablingMemberParty_ses')
end

def tabling_member_parties
get_all_from('tablingMemberParty_ses')
end

def answer_text
get_first_as_html_from('answerText_t')
end
Expand Down Expand Up @@ -100,6 +104,10 @@ def answering_member_party
get_first_from('answeringMemberParty_ses')
end

def answering_member_parties
get_all_from('answeringMemberParty_ses')
end

def question?
true
end
Expand Down
2 changes: 1 addition & 1 deletion app/views/search/fragments/_simple_list.haml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
%span>= terminator
- elsif items.size == 2
%span= object_display_name(items.first, singular: singular)
%span= "; "
%span>= "; "
%span= object_display_name(items.last, singular: singular)
%span>= terminator
- elsif items.size > 2
Expand Down
2 changes: 1 addition & 1 deletion app/views/search/results/_formal_proceeding.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<div class="row">
<div class="three-panel">
<div class="left" id="primary-person">
<%= render 'search/results/item_details/lead_member', lead_member: object.lead_member, lead_member_party: object.lead_member_party %>
<%= render 'search/results/item_details/lead_members', lead_members: object.lead_member, label: 'Lead Member' %>
</div>
<div class="centre" id="secondary-person">
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<div class="row">
<div class="three-panel">
<div class="left" id="primary-person">
<%= render 'search/results/item_details/lead_member', lead_member: object.lead_member, lead_member_party: object.lead_member_party %>
<%= render 'search/results/item_details/lead_members', lead_members: object.lead_members, label: 'Lead Member' %>
</div>
<div class="centre" id="secondary-person">
<%= render 'search/results/item_details/answering_members', answering_members: object.answering_members, label: 'Answering Member' %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/search/results/_ministerial_correction.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<div class="row">
<div class="three-panel">
<div class="left" id="primary-person">
<%= render 'search/results/item_details/member', member: object.member, member_party: object.member_party %>
<%= render 'search/results/item_details/member', member: object.member, member_party: object.member_parties %>
</div>
<div class="centre" id="secondary-person">
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<div class="row">
<div class="three-panel">
<div class="left" id="primary-person">
<%= render 'search/results/item_details/lead_member', lead_member: object.lead_member, lead_member_party: object.lead_member_party %>
<%= render 'search/results/item_details/lead_members', lead_members: object.lead_members, label: 'Lead Member' %>
</div>
<div class="centre" id="secondary-person">
</div>
Expand Down
4 changes: 2 additions & 2 deletions app/views/search/results/_oral_question.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@
<div class="row">
<div class="three-panel">
<div class="left" id="primary-person">
<%= render 'search/results/item_details/asking_or_tabling_member', asking_member: object.asking_member, tabling_member: object.tabling_member, asking_member_party: object.asking_member_party, tabling_member_party: object.tabling_member_party, label: 'Asked by' %>
<%= render 'search/results/item_details/asking_or_tabling_member', asking_member: object.asking_member, tabling_member: object.tabling_member, asking_member_party: object.asking_member_parties, tabling_member_party: object.tabling_member_parties, label: 'Asked by' %>
</div>
<div class="centre" id="secondary-person">
<div <%= 'hidden' unless params[:show_detailed] == "true" %> class="item-details" data-detailed-results-target="toggleHidden">
<%= render 'search/results/item_details/answering_member', answering_member: object.answering_member, answering_member_party: object.answering_member_party, label: 'Answered by' %>
<%= render 'search/results/item_details/answering_member', answering_member: object.answering_member, answering_member_party: object.answering_member_parties, label: 'Answered by' %>
</div>
</div>
<div class="right" id="primary-group">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<div class="row">
<div class="three-panel">
<div class="left" id="primary-person">
<%= render 'search/results/item_details/member', member: object.member, member_party: object.member_party %>
<%= render 'search/results/item_details/member', member: object.member, member_party: object.member_parties %>
</div>
<div class="centre" id="secondary-person">
</div>
Expand Down
2 changes: 1 addition & 1 deletion app/views/search/results/_proceeding_contribution.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<div class="row">
<div class="three-panel">
<div class="left" id="primary-person">
<%= render 'search/results/item_details/member', member: object.member, member_party: object.member_party %>
<%= render 'search/results/item_details/member', member: object.member, member_party: object.member_parties %>
</div>
<div class="centre" id="secondary-person">
</div>
Expand Down
2 changes: 1 addition & 1 deletion app/views/search/results/_written_statement.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<div class="row">
<div class="three-panel">
<div class="left" id="primary-person">
<%= render 'search/results/item_details/member', member: object.member, member_party: object.member_party %>
<%= render 'search/results/item_details/member', member: object.member, member_party: object.member_parties %>
</div>
<div class="centre" id="secondary-person">
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,7 @@
<%= object_display_name(answering_member, singular: false) %>
</span>
<% unless answering_member_party.blank? %>
<span>
(<%= object_display_name(answering_member_party, singular: false) %>)
</span>
(<%= render 'search/fragments/simple_list', items: answering_member_party, terminator: "", singular: false %>)
<% end %>
</div>
<% end %>
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,14 @@
<%= object_display_name(tabling_member, singular: false) %>
</span>
<% unless tabling_member_party.blank? %>
<span>
(<%= object_display_name(tabling_member_party, singular: false) %>)
</span>
(<%= render 'search/fragments/simple_list', items: tabling_member_party, terminator: "", singular: false %>)
<% end %>
<% else %>
<span>
<%= object_display_name(asking_member, singular: false) %>
</span>
<% unless asking_member_party.blank? %>
<span>
(<%= object_display_name(asking_member_party, singular: false) %>)
</span>
(<%= render 'search/fragments/simple_list', items: asking_member_party, terminator: "", singular: false %>)
<% end %>
<% end %>
</div>
Expand Down

0 comments on commit 401dec2

Please sign in to comment.